cpoerschke commented on code in PR #2477: URL: https://github.com/apache/solr/pull/2477#discussion_r1638276023
########## solr/core/src/java/org/apache/solr/update/SegmentTimeLeafSorterSupplier.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.update; + +import java.lang.invoke.MethodHandles; +import java.util.Comparator; +import org.apache.lucene.index.LeafReader; +import org.apache.lucene.index.SegmentReader; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +final class SegmentTimeLeafSorterSupplier implements LeafSorterSupplier { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + private static final String TIME_FIELD = "timestamp"; + private static final SegmentSort DEFAULT_SORT_OPTIONS = SegmentSort.NONE; + + private SegmentSort sortOptions; + private Comparator<LeafReader> leafSorter; + + public SegmentTimeLeafSorterSupplier() { + this(DEFAULT_SORT_OPTIONS); + } + + public SegmentTimeLeafSorterSupplier(SegmentSort sortOptions) { + this.sortOptions = sortOptions; + } + + @Override + public Comparator<LeafReader> getLeafSorter() { + if (leafSorter == null) { + if (SegmentSort.NONE == sortOptions) { + return null; + } + boolean ascSort = SegmentSort.TIME_ASC == sortOptions; + long missingValue = ascSort ? Long.MAX_VALUE : Long.MIN_VALUE; + leafSorter = + Comparator.comparingLong( + r -> { + try { + return Long.parseLong( + ((SegmentReader) r).getSegmentInfo().info.getDiagnostics().get(TIME_FIELD)); Review Comment: Use of the diagnostics here seems very specialised and potentially fragile. Leaf sorting is "between segment sorting" and we also have index sorting i.e. "within segment sorting" -- I wonder if there might be enough commonality to generalise. Will add more detailed scribbles on the https://issues.apache.org/jira/browse/SOLR-17310 ticket itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
