gus-asf commented on PR #2493: URL: https://github.com/apache/solr/pull/2493#issuecomment-2166986928
Am on vacation this week, will try to look Sunday after I get back. On Tue, Jun 11, 2024 at 7:40 PM Hitesh Khamesra ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java > <https://github.com/apache/solr/pull/2493#discussion_r1635595108>: > > > @@ -557,7 +558,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw > while (rb.outgoing.size() == 0) { > ShardResponse srsp = > tolerant > - ? shardHandler1.takeCompletedIncludingErrors() > + ? shardHandler1.takeCompletedIncludingErrorsWithTimeout(maxTimeAllowed) > > Thanks @dsmiley <https://github.com/dsmiley> , I have updated your > feedback. Also @gus-asf <https://github.com/gus-asf> please let me what > you think about it > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/2493#discussion_r1635595108>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ALF2L3MYLS6L6LAIXVTJQODZG6DHTAVCNFSM6AAAAABIW6MUSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJRGYZDMOJYGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- http://www.needhamsoftware.com (work) https://a.co/d/b2sZLD9 (my fantasy fiction book) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
