janhoy commented on code in PR #1930:
URL: https://github.com/apache/solr/pull/1930#discussion_r1329781429
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -343,4 +343,16 @@ public Collection getApis() {
return Collections.singleton(
new
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1329800978
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1725127507
> Would then the preferred access mode for getting properties be via
`EnvUtils.getProp(SolrDispatchFilter.SOLR_DEFAULT_CONFDIR_ATTRIBUTE)` pattern?
I could imagine in a future ticket getting
I wonder if we should strive to be consistent (in either lenient mode or strict
mode) through out Solr? For example, I noticed that the AuthTool does a check
for "true" or "false" with some custom code. If we said that on, off, etc are
all valid choices, then we could support that through ou
joel-bernstein commented on PR #1925:
URL: https://github.com/apache/solr/pull/1925#issuecomment-1725620181
This PR is not building due to conflicts that occurred in CHANGES.txt. I'm
going to create a new clean branch as it seems messy to get this branch past
this problem.
--
This is an
joel-bernstein closed pull request #1925: SOLR-16931: ReRankScaler explain only
works when debugQuery=true, sho…
URL: https://github.com/apache/solr/pull/1925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
joel-bernstein opened a new pull request, #1936:
URL: https://github.com/apache/solr/pull/1936
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
joel-bernstein merged PR #1936:
URL: https://github.com/apache/solr/pull/1936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766825#comment-17766825
]
ASF subversion and git services commented on SOLR-16931:
Commit 1
joel-bernstein opened a new pull request, #1937:
URL: https://github.com/apache/solr/pull/1937
…ibuted mode (#1936)
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull r
[
https://issues.apache.org/jira/browse/SOLR-16987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16987.
Resolution: Duplicate
Already done in [https://github.com/apache/solr/pull/1888] (to be released in
[
https://issues.apache.org/jira/browse/SOLR-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766836#comment-17766836
]
Jan Høydahl commented on SOLR-16979:
Awaiting merging to 9x until we know whether som
[
https://issues.apache.org/jira/browse/SOLR-16988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16988:
Description:
This is a followup of the rid deprecation task SOLR-15367 to remove all rid
related c
Alex Deparvu created SOLR-16988:
---
Summary: Remove rid support
Key: SOLR-16988
URL: https://issues.apache.org/jira/browse/SOLR-16988
Project: Solr
Issue Type: Improvement
Security Level: P
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu resolved SOLR-15367.
-
Fix Version/s: 9.4
Resolution: Fixed
all work is completed. marking as resolved.
> Conver
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766839#comment-17766839
]
Alex Deparvu commented on SOLR-15367:
-
created SOLR-16988 to track rid removal.
> Co
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1725835250
> Just updated the docs.
>
> When circuit breakers are enabled for update requests, how does that work
for replicas? Can an NRT replica get out of sync by rejecting a request? It
should be
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1725839365
@wrunderwood Are you planning to incorporate latest review feedback and
prepare for merge? I try to get this landed before 9.4.
--
This is an automated message from the Apache Git Service.
To r
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1725848926
Widening the review to get more perspectives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
janhoy commented on PR #1908:
URL: https://github.com/apache/solr/pull/1908#issuecomment-1725858904
@noblepaul do you want to have a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1330303030
##
solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestDistributedTracing.java:
##
@@ -173,20 +167,137 @@ public void testV2Api() throws Exception {
stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1330307016
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -150,4 +167,11 @@ public static void setOperations(SolrQueryRequest req,
String clazz, List St
joel-bernstein merged PR #1937:
URL: https://github.com/apache/solr/pull/1937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766844#comment-17766844
]
ASF subversion and git services commented on SOLR-16931:
Commit 3
stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1330307016
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -150,4 +167,11 @@ public static void setOperations(SolrQueryRequest req,
String clazz, List St
pjmcarthur commented on code in PR #1926:
URL: https://github.com/apache/solr/pull/1926#discussion_r1330310547
##
solr/core/src/java/org/apache/solr/cluster/maintenance/InactiveShardRemover.java:
##
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1330307016
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -150,4 +167,11 @@ public static void setOperations(SolrQueryRequest req,
String clazz, List St
stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1330307016
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -150,4 +167,11 @@ public static void setOperations(SolrQueryRequest req,
String clazz, List St
[
https://issues.apache.org/jira/browse/SOLR-16988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16988:
Component/s: tracing
> Remove rid support
> --
>
> Key: SOLR-16988
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1330341363
##
solr/core/src/resources/EnvToSyspropMappings.properties:
##
@@ -0,0 +1,60 @@
+# Mapping from Environment variable to system property
+# This file only contains non-stand
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1330341363
##
solr/core/src/resources/EnvToSyspropMappings.properties:
##
@@ -0,0 +1,60 @@
+# Mapping from Environment variable to system property
+# This file only contains non-stand
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1330348141
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766860#comment-17766860
]
Jason Gerlowski commented on SOLR-16691:
Two things:
# I was reading through a [
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766861#comment-17766861
]
ASF subversion and git services commented on SOLR-16931:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766862#comment-17766862
]
ASF subversion and git services commented on SOLR-16931:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein resolved SOLR-16931.
---
Resolution: Fixed
> ReRankScaler explain breaks with debug=true and in distributed mode
> ---
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-16931:
--
Fix Version/s: 9.4
> ReRankScaler explain breaks with debug=true and in distributed mode
>
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein reopened SOLR-16931:
---
> ReRankScaler explain breaks with debug=true and in distributed mode
> -
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein resolved SOLR-16931.
---
Resolution: Resolved
> ReRankScaler explain breaks with debug=true and in distributed mode
>
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766860#comment-17766860
]
Jason Gerlowski edited comment on SOLR-16691 at 9/19/23 4:00 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766869#comment-17766869
]
Jason Gerlowski commented on SOLR-16691:
And one final question: should we deprec
wrunderwood commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1330486585
##
solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc:
##
@@ -48,19 +63,25 @@ To enable and configure the JVM heap usage based circuit
breaker, add
wrunderwood commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1726208757
I think I've fixed the things called out, but I might have missed something.
I don't use GitHub very often.
Let me know if I left something unresolved. It all looks good to me, thanks
tflobbe merged PR #1931:
URL: https://github.com/apache/solr/pull/1931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766899#comment-17766899
]
ASF subversion and git services commented on SOLR-16978:
Commit 5
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1726255785
> Let me know if I left something unresolved. It all looks good to me,
thanks of the improvements over my patch.
Thanks. There are two "unresolved conversations" in the PR that you may want
janhoy merged PR #1934:
URL: https://github.com/apache/solr/pull/1934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe resolved SOLR-16978.
--
Fix Version/s: main (10.0)
9.4
Resolut
[
https://issues.apache.org/jira/browse/SOLR-16978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766903#comment-17766903
]
ASF subversion and git services commented on SOLR-16978:
Commit 3
HoustonPutman commented on PR #1782:
URL: https://github.com/apache/solr/pull/1782#issuecomment-1726297876
**testConfigset** is failing pretty consistently on Jenkins (50%):
https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/8012/testReport/org.apache.solr.search/TestCoordinatorRole/t
gerlowskija commented on PR #1903:
URL: https://github.com/apache/solr/pull/1903#issuecomment-1726301468
> I have tried the POST request without Content-type header, and it returns
415 Unsupported Media Type. Why I am saying this? Because as per our last
discussion, It supposed to work with
gerlowskija commented on code in PR #1903:
URL: https://github.com/apache/solr/pull/1903#discussion_r1330550101
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReloadCoreAPI.java:
##
@@ -17,52 +17,69 @@
package org.apache.solr.handler.admin.api;
-import static org.a
[
https://issues.apache.org/jira/browse/SOLR-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney reassigned SOLR-16989:
-
Assignee: Michael Gibney
> Consolidate reuse of DocValues iterators for value retrieval
Michael Gibney created SOLR-16989:
-
Summary: Consolidate reuse of DocValues iterators for value
retrieval
Key: SOLR-16989
URL: https://issues.apache.org/jira/browse/SOLR-16989
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-16989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney updated SOLR-16989:
--
Summary: Optimize and consolidate reuse of DocValues iterators for value
retrieval (was: Conso
magibney commented on PR #646:
URL: https://github.com/apache/solr/pull/646#issuecomment-1726327942
obviated by https://github.com/apache/solr/pull/1351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
magibney closed pull request #646: SOLR-16017: Allow first registered
SolrIndexSearcher to inform its configured caches
URL: https://github.com/apache/solr/pull/646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
patsonluk commented on PR #1782:
URL: https://github.com/apache/solr/pull/1782#issuecomment-1726332511
> **testConfigset** is failing pretty consistently on Jenkins (50%):
https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/8012/testReport/org.apache.solr.search/TestCoordinatorRole/tes
wrunderwood commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1330607590
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.coda
gerlowskija merged PR #1903:
URL: https://github.com/apache/solr/pull/1903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766911#comment-17766911
]
ASF subversion and git services commented on SOLR-16397:
Commit 5
gerlowskija commented on PR #1903:
URL: https://github.com/apache/solr/pull/1903#issuecomment-1726354714
Thanks for the contribution Sanjay! I've merged to `main` and will try to
backport for 9.4 towards the end of this week!
--
This is an automated message from the Apache Git Service.
T
wrunderwood commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1726362729
I think that is everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
magibney commented on code in PR #1460:
URL: https://github.com/apache/solr/pull/1460#discussion_r1323505098
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1627,6 +1627,20 @@ private DocCollection fetchCollectionState(String coll,
Watch
HoustonPutman merged PR #610:
URL: https://github.com/apache/solr-operator/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman closed issue #609: Fix Solr probes w/TLS for Solr 9.2+
URL: https://github.com/apache/solr-operator/issues/609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
patsonluk opened a new pull request, #1939:
URL: https://github.com/apache/solr/pull/1939
https://issues.apache.org/jira/browse/SOLR-16890
# Description
The test cases addd in https://github.com/apache/solr/pull/1782 quite
frequently (~50%) triggers exceptions like below
patsonluk commented on PR #1782:
URL: https://github.com/apache/solr/pull/1782#issuecomment-1726436517
@HoustonPutman I have created a fix PR
https://github.com/apache/solr/pull/1939, would u mind to review it?
I have to use `HttpSolrClient` instead of `Http2SolrClient` as only the
f
patsonluk commented on code in PR #1460:
URL: https://github.com/apache/solr/pull/1460#discussion_r1330699417
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1627,6 +1627,20 @@ private DocCollection fetchCollectionState(String coll,
Watc
patsonluk commented on code in PR #1460:
URL: https://github.com/apache/solr/pull/1460#discussion_r1330700685
##
solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java:
##
@@ -73,4 +76,68 @@ public static boolean injectDelay() {
}
return true;
}
+
patsonluk commented on code in PR #1460:
URL: https://github.com/apache/solr/pull/1460#discussion_r1330700685
##
solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java:
##
@@ -73,4 +76,68 @@ public static boolean injectDelay() {
}
return true;
}
+
patsonluk commented on PR #1939:
URL: https://github.com/apache/solr/pull/1939#issuecomment-1726481385
Would u mind to approve the workflow and merge for us? I don't want to break
the test cases for too long 😂
--
This is an automated message from the Apache Git Service.
To respond to the
janhoy opened a new pull request, #1940:
URL: https://github.com/apache/solr/pull/1940
(cherry picked from commit cebc3f0f479b2c40eb8161864cef7157fda36b16)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1330787224
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codahale.
[
https://issues.apache.org/jira/browse/SOLR-16983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-16983:
--
Attachment: SOLR-16983-1.patch
Status: Open (was: Open)
I've updated the patch
[
https://issues.apache.org/jira/browse/SOLR-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766941#comment-17766941
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-16852:
--
Sorry for th
[
https://issues.apache.org/jira/browse/SOLR-16852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766994#comment-17766994
]
David Smiley commented on SOLR-16852:
-
I'm not very familiar with snapshots TBH but I
dsmiley commented on code in PR #1926:
URL: https://github.com/apache/solr/pull/1926#discussion_r1331009854
##
solr/core/src/java/org/apache/solr/cluster/maintenance/InactiveShardRemover.java:
##
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766997#comment-17766997
]
Noble Paul commented on SOLR-16691:
---
{quote}should we deprecate JsonResponseWriter now
dsmiley merged PR #1901:
URL: https://github.com/apache/solr/pull/1901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766997#comment-17766997
]
Noble Paul edited comment on SOLR-16691 at 9/20/23 5:28 AM:
{
[
https://issues.apache.org/jira/browse/SOLR-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766997#comment-17766997
]
Noble Paul edited comment on SOLR-16691 at 9/20/23 5:29 AM:
{
82 matches
Mail list logo
