wrunderwood commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1330607590
########## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ########## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.metrics.Gauge; +import com.codahale.metrics.Metric; import java.lang.invoke.MethodHandles; -import java.lang.management.ManagementFactory; -import java.lang.management.OperatingSystemMXBean; +import org.apache.solr.core.SolrCore; +import org.apache.solr.metrics.SolrMetricManager; import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** * Tracks current CPU usage and triggers if the specified threshold is breached. * - * <p>This circuit breaker gets the average CPU load over the last minute and uses that data to take - * a decision. We depend on OperatingSystemMXBean which does not allow a configurable interval of - * collection of data. //TODO: Use Codahale Meter to calculate the value locally. - * - * <p>The configuration to define which mode to use and the trigger threshold are defined in - * solrconfig.xml + * <p>This circuit breaker gets the recent average CPU usage and uses that data to take a decision. + * We depend on OperatingSystemMXBean which does not allow a configurable interval of collection of Review Comment: I think this is OK, since it describes the external behavior of the class. Compare it to the comment in LoadAverageCircuitBreaker.java, which is very similar. I've added a couple of comments in calculateLiveCPUUsage() where it tries to get the Metric object and might fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
