stillalex commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1330307016
##########
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##########
@@ -150,4 +167,11 @@ public static void setOperations(SolrQueryRequest req,
String clazz, List<String
req.getSpan().setAttribute(TAG_CLASS, clazz);
}
}
+
+ public static Span newInterNodeCommunicationSpan(String name, String
collection) {
Review Comment:
> Still waiting on the SpanKind change to be "async" based.
not sure what you are referring to. just to clarify the type is `CONSUMER`
now, as discussed above.
a bit more context:
https://opentelemetry.io/docs/specs/otel/trace/api/#spankind
both `PRODUCER` and `CONSUMER` are considered async. we were debating which
to pick for this span.
> It isn't necessarily "interNodeCommunicationSpan" and I'm not sure that
internNode vs non-InterNode is meaningful.
I agree the naming is awkward. it could be clearer like
`newCollectionApiCommandSpan`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
