[jira] [Created] (SOLR-16621) Admin UI fails to grant user permissions that have wildcard role

2023-01-17 Thread Jira
Jan Høydahl created SOLR-16621: -- Summary: Admin UI fails to grant user permissions that have wildcard role Key: SOLR-16621 URL: https://issues.apache.org/jira/browse/SOLR-16621 Project: Solr Is

[GitHub] [solr] janhoy opened a new pull request, #1294: SOLR-16621: Admin UI fails to grant user permissions with wildcard role

2023-01-17 Thread GitBox
janhoy opened a new pull request, #1294: URL: https://github.com/apache/solr/pull/1294 https://issues.apache.org/jira/browse/SOLR-16621 Always grant access to a permission that has has the wildcard `"*"` role, no matter what roles user has. Note, this is not the same as not requiri

[GitHub] [solr] janhoy commented on pull request #1294: SOLR-16621: Admin UI fails to grant user permissions with wildcard role

2023-01-17 Thread GitBox
janhoy commented on PR #1294: URL: https://github.com/apache/solr/pull/1294#issuecomment-1385173003 @thelabdude I see some duplicate logic in the permission check for Security Dash. I believe you could have used the function `isPermitted()` already defined in `app.js`, see https://github.c

[GitHub] [solr] janhoy opened a new pull request, #1295: Use $scope.isPermitted("my-permissiong") in security dash

2023-01-17 Thread GitBox
janhoy opened a new pull request, #1295: URL: https://github.com/apache/solr/pull/1295 Re-using this global function, we can simplify the js code of the dashboard. Note that the backend `/admin/info/system` already returns an array of user's permissions, not roles. During testing I f

[GitHub] [solr] janhoy commented on pull request #1295: Use $scope.isPermitted("my-permissiong") in security dash

2023-01-17 Thread GitBox
janhoy commented on PR #1295: URL: https://github.com/apache/solr/pull/1295#issuecomment-1385290310 I also found that `security.js` redefined the global `$scope.permissions` also defined in `app.js` which holds a static map of all permission names. I renamed the variable to `$scope.permissi

[jira] [Created] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-16622: --- Summary: Replicas don't come up active after node restart Key: SOLR-16622 URL: https://issues.apache.org/jira/browse/SOLR-16622 Project: Solr I

[jira] [Commented] (SOLR-16414) Race condition in PRS state updates

2023-01-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677741#comment-17677741 ] ASF subversion and git services commented on SOLR-16414: Commit d

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677740#comment-17677740 ] ASF subversion and git services commented on SOLR-16622: Commit d

[jira] [Resolved] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-16622. - Fix Version/s: 9.1.1 Resolution: Fixed FYI [~magibney] > Replicas don't c

[jira] [Commented] (SOLR-16525) Periodic performance benchmarking

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677743#comment-17677743 ] Ishan Chattopadhyaya commented on SOLR-16525: - Fixed the issue: SOLR-16622. C

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677744#comment-17677744 ] ASF subversion and git services commented on SOLR-16622: Commit f

[jira] [Commented] (SOLR-16621) Admin UI fails to grant user permissions that have wildcard role

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677753#comment-17677753 ] Jan Høydahl commented on SOLR-16621: Plan to target 9.2 with this > Admin UI fails t

[GitHub] [solr] janhoy opened a new pull request, #1296: SOLR-15772 More visible security warnings in Admin UI

2023-01-17 Thread GitBox
janhoy opened a new pull request, #1296: URL: https://github.com/apache/solr/pull/1296 https://issues.apache.org/jira/browse/SOLR-15772 I know I should have chosen some other class to get `text-align: left` and not put the style on the div tag, but I was too lazy to investigate what c

[jira] [Updated] (SOLR-15772) More visible security warnings in Admin UI

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15772: --- Attachment: Skjermbilde 2023-01-17 kl. 14.42.04.png > More visible security warnings in Admin UI > --

[jira] [Commented] (SOLR-15772) More visible security warnings in Admin UI

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1761#comment-1761 ] Jan Høydahl commented on SOLR-15772: With suggested PR this will look like this on th

[jira] [Assigned] (SOLR-15772) More visible security warnings in Admin UI

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-15772: -- Assignee: Jan Høydahl > More visible security warnings in Admin UI > -

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677784#comment-17677784 ] Kevin Risden commented on SOLR-16622: - Why was this pushed directly to the release br

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677786#comment-17677786 ] Michael Gibney commented on SOLR-16622: --- Thanks for catching this and backporting.

[GitHub] [solr] janhoy opened a new pull request, #1297: SOLR-14336 Warn users running old version of Solr

2023-01-17 Thread GitBox
janhoy opened a new pull request, #1297: URL: https://github.com/apache/solr/pull/1297 https://issues.apache.org/jira/browse/SOLR-14336 This impl will simply parse release date from solr-impl string, count number of days old, and warn in Admin UI dashboard if older than a year. No war

[jira] [Updated] (SOLR-14336) Warn users running old version of Solr

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-14336: --- Attachment: Skjermbilde 2023-01-17 kl. 15.25.49.png > Warn users running old version of Solr > --

[jira] [Commented] (SOLR-14336) Warn users running old version of Solr

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677790#comment-17677790 ] Jan Høydahl commented on SOLR-14336: This is how it looks like (I forced it to displa

[jira] [Assigned] (SOLR-14336) Warn users running old version of Solr

2023-01-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-14336: -- Assignee: Jan Høydahl > Warn users running old version of Solr > -

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677800#comment-17677800 ] Ishan Chattopadhyaya commented on SOLR-16622: - bq. Why was this pushed direct

[jira] [Comment Edited] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677800#comment-17677800 ] Ishan Chattopadhyaya edited comment on SOLR-16622 at 1/17/23 3:15 PM: -

[jira] [Comment Edited] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677800#comment-17677800 ] Ishan Chattopadhyaya edited comment on SOLR-16622 at 1/17/23 3:16 PM: -

[jira] [Updated] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16622: Attachment: Screenshot from 2023-01-17 15-03-05.png > Replicas don't come up active

[GitHub] [solr] magibney commented on pull request #1291: buildAndPushRelease should optionally pause before assembleRelease

2023-01-17 Thread GitBox
magibney commented on PR #1291: URL: https://github.com/apache/solr/pull/1291#issuecomment-1385592060 Thanks, Kevin and Jan! I did a dry-run of this (and also #1290), and both worked as intended. I'll merge and incorporate testing this out "in real life" while building 9.1.1 RC2. (It

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677806#comment-17677806 ] Ishan Chattopadhyaya commented on SOLR-16622: - bq. I'm curious whether you ha

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677809#comment-17677809 ] Ishan Chattopadhyaya commented on SOLR-16622: - I think all this just shows th

[jira] [Updated] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16622: Description: While benchmarking for performance, we saw a sharp change in the graph

[jira] [Commented] (SOLR-14336) Warn users running old version of Solr

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677810#comment-17677810 ] Ishan Chattopadhyaya commented on SOLR-14336: - Lets add a "Please"? > Warn u

[jira] [Commented] (SOLR-14336) Warn users running old version of Solr

2023-01-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677843#comment-17677843 ] Houston Putman commented on SOLR-14336: --- Yeah I think this is perfect with Ishan's

[jira] [Commented] (SOLR-16622) Replicas don't come up active after node restart

2023-01-17 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677868#comment-17677868 ] Michael Gibney commented on SOLR-16622: --- Thanks for this extra context, it's really

[GitHub] [solr] magibney merged pull request #1290: releaseWizard: allow explicitly setting manifest.mf userid (e.g., to apache id)

2023-01-17 Thread GitBox
magibney merged PR #1290: URL: https://github.com/apache/solr/pull/1290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[GitHub] [solr] magibney merged pull request #1291: buildAndPushRelease should optionally pause before assembleRelease

2023-01-17 Thread GitBox
magibney merged PR #1291: URL: https://github.com/apache/solr/pull/1291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[jira] [Updated] (SOLR-15616) Allow thread metrics to be cached

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-15616: Attachment: SOLR-15616-2.patch Status: Open (was: Open) Changed the cachin

[GitHub] [solr] noblepaul commented on pull request #1210: SOLR-16347: Skip JerseyApp creation when v2 disabled

2023-01-17 Thread GitBox
noblepaul commented on PR #1210: URL: https://github.com/apache/solr/pull/1210#issuecomment-1385915397 @gerlowskija we should keep this `disabled` by default so that performance testing is not blocked -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-17 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677899#comment-17677899 ] Andrzej Bialecki commented on SOLR-15616: - LGTM, thanks for seeing this through,

[jira] [Commented] (SOLR-12779) Force field/term centric matching mode for multi-term synonyms with sow=false

2023-01-17 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677902#comment-17677902 ] Rudi Seitz commented on SOLR-12779: --- Linking to SOLR-16594 which contains a proposal fo

[jira] [Commented] (SOLR-15616) Allow thread metrics to be cached

2023-01-17 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677903#comment-17677903 ] Ishan Chattopadhyaya commented on SOLR-15616: - Good idea, I'll add the "Sec"

[jira] [Commented] (SOLR-16438) Shard split should be able to set preferred leaders on other replicas

2023-01-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677926#comment-17677926 ] Houston Putman commented on SOLR-16438: --- {{SplitShardTest.testConcurrentSplitThreeH

[GitHub] [solr] gerlowskija commented on pull request #1286: SOLR-16615: Reuse Jersey apps for cores with the same configset

2023-01-17 Thread GitBox
gerlowskija commented on PR #1286: URL: https://github.com/apache/solr/pull/1286#issuecomment-1386285201 Hey @risdenk : I was hoping to gear up to merge, but see you still technically have an outstanding "change requested" on this PR. 99% sure this was the 'Suggested Change' to fix precomm

[GitHub] [solr] dsmiley commented on pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-17 Thread GitBox
dsmiley commented on PR #1243: URL: https://github.com/apache/solr/pull/1243#issuecomment-1386457113 I marked the pertinent classes deprecated, added a note about this in the upgrade notes, and added this CHANGES.txt entry: > SOLR-16591: The "Transient Cores" feature is now deprecated. I

[GitHub] [solr] dsmiley commented on pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-17 Thread GitBox
dsmiley commented on PR #1243: URL: https://github.com/apache/solr/pull/1243#issuecomment-1386457707 I plan to commit in a couple days if I don't hear to the contrary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [solr] dsmiley commented on a diff in pull request #1218: SOLR-16573:SolrClientTestRule for EmbeddedSolrServer

2023-01-17 Thread GitBox
dsmiley commented on code in PR #1218: URL: https://github.com/apache/solr/pull/1218#discussion_r1073134160 ## solr/test-framework/src/java/org/apache/solr/util/EmbeddedSolrServerTestRule.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Created] (SOLR-16623) SolrClientTestRule for JettySolrRunner

2023-01-17 Thread David Smiley (Jira)
David Smiley created SOLR-16623: --- Summary: SolrClientTestRule for JettySolrRunner Key: SOLR-16623 URL: https://issues.apache.org/jira/browse/SOLR-16623 Project: Solr Issue Type: Sub-task

[GitHub] [solr] noblepaul merged pull request #1293: SOLR-16593 : Redundant fields are present in the replica object of state.json

2023-01-17 Thread GitBox
noblepaul merged PR #1293: URL: https://github.com/apache/solr/pull/1293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16593) Redundant fields are present in the replica object of state.json

2023-01-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678097#comment-17678097 ] ASF subversion and git services commented on SOLR-16593: Commit 1

[jira] [Commented] (SOLR-16593) Redundant fields are present in the replica object of state.json

2023-01-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678107#comment-17678107 ] ASF subversion and git services commented on SOLR-16593: Commit a

[jira] [Resolved] (SOLR-16593) Redundant fields are present in the replica object of state.json

2023-01-17 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16593. --- Fix Version/s: 9.2 Resolution: Fixed > Redundant fields are present in the replica object of s