[
https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677899#comment-17677899
]
Andrzej Bialecki commented on SOLR-15616:
-----------------------------------------
LGTM, thanks for seeing this through, Ishan!
One minor suggestion: since the interval is expressed in seconds (whereas often
other intervals are expressed in millis) maybe we should use
`threadIntervalSec` or something like that? I leave it up to you - the docs say
it's in seconds but if it's in the name then it's self-explanatory.
> Allow thread metrics to be cached
> ---------------------------------
>
> Key: SOLR-15616
> URL: https://issues.apache.org/jira/browse/SOLR-15616
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Priority: Major
> Attachments: SOLR-15616-2.patch, SOLR-15616-9x.patch,
> SOLR-15616.patch, SOLR-15616.patch
>
>
> Computing JVM metrics for threads can be expensive, and we should provide
> option to users to avoid doing so on every call to the metrics API
> (group=jvm).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
