janhoy commented on PR #1294: URL: https://github.com/apache/solr/pull/1294#issuecomment-1385173003
@thelabdude I see some duplicate logic in the permission check for Security Dash. I believe you could have used the function `isPermitted()` already defined in `app.js`, see https://github.com/apache/solr/blob/main/solr/webapp/web/js/angular/app.js#L528-L533 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
