dsmiley merged PR #3048:
URL: https://github.com/apache/solr/pull/3048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2627271485
> As you are a very new contributor, I can tell by your changes and your
last question that you have not been running `./gradlew precommit`, which will
detect issues that you can correct bef
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2625909437
As you are a very new contributor, I can tell by your changes and your last
question that you have not been running `./gradlew precommit`, which will
detect issues that you can correct befor
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2625544960
> I removed the asShallowMap returning SimpleOrderedMap so such a decision
can be in Solr 10. I intend on merging this when the tests pass and back
porting to 9x. Today/tomorrow. Thanks agai
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2625396992
I removed the asShallowMap returning SimpleOrderedMap so such a decision can
be in Solr 10.
I intend on merging this when the tests pass and back porting to 9x.
Today/tomorrow.
Thanks
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2622942999
> have a slight concern if there's existing code relying on quirky sad
behaviors of NamedList.asShallowMap having weird/sad implementations of
`keySet`, `values`, `entrySet` because it calls
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2622728797
> Just needs a CHANGES.txt entry.
I've added that under Solr 9.9.0, is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1934300672
##
solr/solrj/src/java/org/apache/solr/common/util/NamedList.java:
##
@@ -238,6 +238,14 @@ public int indexOf(String name, int start) {
return -1;
}
+ /***
+
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2622011097
> **Separately** in another issue/pr, NamedList needs some more attention
around this and toMap. Definitely deprecating that one.
I interpreted you thumbs up on my comment early as OK
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2621748542
> Wouldn't it be a better approach just to override asShallowMap in
SimpleOrderedMap and return itself?
:face-palm: of course; wow I have no excuse for myself. Not enough coffee
mayb
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2620972046
> As part of this PR, let's have NamedList.asShallowMap do an instanceof
check for Map and return it if so. That will lead to real usage / code coverage
of the changes you've done.
Wo
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1933308834
##
solr/solrj/build.gradle:
##
@@ -48,7 +48,6 @@ dependencies {
})
implementation libs.apache.httpcomponents.httpclient
implementation libs.apache.httpcomponents.
cpoerschke commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1932629861
##
solr/solrj/build.gradle:
##
@@ -81,7 +81,7 @@ dependencies {
testRuntimeOnly(libs.eclipse.jetty.alpnjavaserver, {
exclude group: "org.eclipse.jetty.alpn", mo
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1929111648
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOr
renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1928520200
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOr
renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1928511029
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOr
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1927992917
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -68,24 +74,153 @@ public SimpleOrderedMap(Map.Entry[]
nameValuePairs) {
public SimpleOr
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2610858357
@dsmiley Please have another look, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605960508
I would implement the methods here, copying bits of code from #3050 if
needed so that you don't call NamedList.asShallowMap. Take from that whatever
you want. I'm not sure NamedList.asShal
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605722808
@dsmiley Considering your improvements on NamedList..asShallowMap, could I
just delegate the method keySet, values and entrySet to the shallowMap e.g. :
public Collection values() {
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2605415831
> I am curious if there is a way to implement values() and entrySet(0
without an unchecked cast, e.g. (T) nvPairs.get(i)
Almost nobody could answer a cast question like that without li
renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1922882654
##
solr/solrj/src/test/org/apache/solr/common/util/SimpleOrderedMapTest.java:
##
@@ -0,0 +1,125 @@
+package org.apache.solr.common.util;
+
+import java.util.Collection;
+i
renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1922881412
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -86,6 +91,79 @@ public static SimpleOrderedMap of() {
* @return SimpleOrderedMap contai
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1922851418
##
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##
@@ -86,6 +91,79 @@ public static SimpleOrderedMap of() {
* @return SimpleOrderedMap contai
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2603231369
As the PR template indicates, the PR title must use exactly the JIRA syntax.
Thus all-caps and hyphen separating SOLR and 17623, probably then a colon. If
you do it correctly, moments late
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2603171608
I am curious if there is a way to implement values() and entrySet(0 without
an unchecked cast, e.g. (T) nvPairs.get(i)
--
This is an automated message from the Apache Git Service.
To resp
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2603163228
@dsmiley Could you please have a look at the implementation oaf the method
from the Map interface?
Also, I had to make a few adjustment to other parts in the code to make it
work with th
epugh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2603160290
Nitpicky, but can you title the PR `SOLR-17623:`, that is the style we use...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
28 matches
Mail list logo
