renatoh commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1922881412
##########
solr/solrj/src/java/org/apache/solr/common/util/SimpleOrderedMap.java:
##########
@@ -86,6 +91,79 @@ public static SimpleOrderedMap<Object> of() {
* @return SimpleOrderedMap containing one key-value pair
*/
public static <T> SimpleOrderedMap<T> of(String name, T val) {
- return new SimpleOrderedMap<>(List.of(name, val));
+ return new SimpleOrderedMap<T>(List.of(name, val));
+ }
+
+ @Override
+ public boolean isEmpty() {
+ return nvPairs.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(final Object key) {
+ return super.get((String) key) != null;
+ }
+
+ @Override
+ public boolean containsValue(final Object value) {
+ int sz = size();
+ for (int i = 0; i < sz; i++) {
+ T val = getVal(i);
+ if (Objects.equals(value, val)) {
+ return true;
+ }
+ }
+ return false;
+ }
+
+ @Override
+ public T get(final Object key) {
+ return super.get((String) key);
+ }
+
+ @Override
+ public T put(final String key, final T value) {
+ T oldValue = get(key);
+ add(key, value);
+ return oldValue;
+ }
+
+ @Override
+ public T remove(final Object key) {
+ return super.remove((String) key);
+ }
+
+ @Override
+ public void putAll(final Map<? extends String, ? extends T> m) {
+ m.forEach(this::put);
+ }
+
+ @Override
+ public Set<String> keySet() {
+ var keys = new HashSet<String>();
Review Comment:
How else should I collect every other entry from the nvPairs into Set?
The only other way I can think of is to use a .stream()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
