dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2621748542

   > Wouldn't it be a better approach just to override asShallowMap in 
SimpleOrderedMap and return itself?
   
   :face-palm: of course; wow I have no excuse for myself.  Not enough coffee 
maybe.
   
   > Additionally,I have noticed that 
org.apache.solr.common.util.NamedList#asShallowMap(boolean) is not called 
outside NamedList, do we want to set it to private?
   
   **Separately** in another issue/pr, NamedList needs some more attention 
around this and toMap.  Definitely deprecating that one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to