malliaridis commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2479585040
I have updated the documentation to hopefully be clearer, but it is still
not perfect yet. I have created
https://issues.apache.org/jira/browse/SOLR-17563 to address outdated
documentat
malliaridis merged PR #2706:
URL: https://github.com/apache/solr/pull/2706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gus-asf commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1842696769
##
dev-docs/dependency-upgrades.adoc:
##
@@ -16,30 +16,34 @@
// specific language governing permissions and limitations
// under the License.
-Solr has lots of 3rd par
gus-asf commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1842431080
##
dev-docs/dependency-upgrades.adoc:
##
@@ -16,30 +16,34 @@
// specific language governing permissions and limitations
// under the License.
-Solr has lots of 3rd par
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1841589725
##
help/dependencies.txt:
##
@@ -100,12 +166,12 @@ If you want to upgrade Lucene to a newer build proceed
like the following:
queued)
- remember the build number
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1841589266
##
dev-docs/dependency-upgrades.adoc:
##
@@ -16,30 +16,34 @@
// specific language governing permissions and limitations
// under the License.
-Solr has lots of 3rd
malliaridis commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2475456393
Thanks @gus-asf for your review and input. Your questions are pointing out
some of our upcoming TODOs. I'll leave some comments about the current state on
each of your comments, hopefull
gus-asf commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1840660878
##
dev-docs/dependency-upgrades.adoc:
##
@@ -16,30 +16,34 @@
// specific language governing permissions and limitations
// under the License.
-Solr has lots of 3rd par
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1840370734
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
risdenk commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1838502296
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
Stri
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1838332962
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
risdenk commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1837043013
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
Stri
risdenk commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1837032264
##
solr/core/src/test/org/apache/solr/handler/admin/api/UnloadCoreAPITest.java:
##
@@ -56,7 +56,6 @@ public void setUp() throws Exception {
public void testValidUnloadC
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1836144609
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1836149307
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,460 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NO
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1836145111
##
solr/core/src/test/org/apache/solr/handler/admin/IndexSizeEstimatorTest.java:
##
@@ -227,8 +227,9 @@ public void testIntegration() throws Exception {
(k,
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1836144609
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1836036572
##
solr/licenses/netty-NOTICE.txt:
##
@@ -162,9 +170,9 @@ This product optionally depends on 'JBoss Marshalling', an
alternative Java
serialization API, which can be
risdenk commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1835795810
##
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##
@@ -92,8 +92,7 @@ public void init(final NamedList args) {
Stri
dsmiley commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1835784148
##
solr/licenses/netty-NOTICE.txt:
##
@@ -162,9 +170,9 @@ This product optionally depends on 'JBoss Marshalling', an
alternative Java
serialization API, which can be obt
malliaridis commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2466308671
The current state should differ now only in hamcrest-core, which is being
merged with hamcrest in the `dependencies.gradle`.
--
This is an automated message from the Apache Git Service
malliaridis commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2417694767
I think it would be a good idea to first resolve the current solrbot PRs
before aligning the versions. I am already looking into some of the PRs to see
how they can be resolved.
--
Th
dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2412356157
I think the next step is just some dependency version alignment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2380893395
I checked out this branch and did `gw assemble` then renamed
`solr/packaging/build/solr-10.0.0-SNAPSHOT/` to have an "-after" suffix. Then
I checked out a recent main (before cross-DC addit
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775253658
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
dweiss commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775243765
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775243589
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NO
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775234820
##
build.gradle:
##
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/
janhoy commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775192261
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
dweiss commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775139816
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
-
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775109063
##
build.gradle:
##
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775107083
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
dweiss commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1775026121
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,432 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE
dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2373053917
> spotless and tidy are added to run on build files too
Awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dsmiley commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1774499355
##
build.gradle:
##
@@ -139,7 +143,7 @@ apply from: file('gradle/maven/defaults-maven.gradle')
// IDE support, settings and specials.
apply from: file('gradle/ide/inte
malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1761060353
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
janhoy commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1761009874
##
help/dependencies.txt:
##
@@ -29,60 +29,126 @@ testImplementation - makes a dependency only available for
test classes.
Adding a library dependency
-
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2345913148
This PR is closed in favor to #2706, which does not include all the
dependency updates made here. They will be resolved in separate PRs.
--
This is an automated message from the Apache
malliaridis closed pull request #2646: SOLR-17406: Introduce Version Catalogs
URL: https://github.com/apache/solr/pull/2646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
malliaridis opened a new pull request, #2706:
URL: https://github.com/apache/solr/pull/2706
https://issues.apache.org/jira/browse/SOLR-17406
# Description
With the version catalogs all versions and references to them are managed in
a single file and updated from there.
#
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2307147732
Yeah I agree. I already started the process of splitting the PR into two,
one for infra and one for the dependency updates. I am facing a few version
differences with non-conflicting dep
dweiss commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2306992445
I would keep any upgrades from infrastructure changes separate. You can then
diff/ compare the final artifacts and see what's changed before doing any
updates.
--
This is an automated mess
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2295068582
I think it was a mistake adding
[f402a0b](https://github.com/apache/solr/pull/2646/commits/f402a0b41ce37a7f6861f1d36d6a67ebbd77e3e6)
onwards in the same PR, even thought there were only
malliaridis commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2288914963
@iamsanjay That would be great. We probably have to add the
[foojay-resolver-plugin](https://plugins.gradle.org/plugin/org.gradle.toolchains.foojay-resolver-convention)
too at some point
iamsanjay commented on PR #2646:
URL: https://github.com/apache/solr/pull/2646#issuecomment-2288860568
If this change is intended for Solr 10, it should be tested and developed
using Java 21 to ensure there are no hidden surprises. I have one PR that makes
Solr compatible with Java 21, but
malliaridis opened a new pull request, #2646:
URL: https://github.com/apache/solr/pull/2646
https://issues.apache.org/jira/browse/SOLR-17406
# Description
With Gradle it is possible to manage versions and dependencies in gradle
files via version catalogs. This allows us to clea
46 matches
Mail list logo
