risdenk commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1837043013
##########
solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java:
##########
@@ -92,8 +92,7 @@ public void init(final NamedList<?> args) {
String algorithmString = params.get(ALGORITHM_PARAM);
Algorithm classificationAlgorithm;
try {
- if (algorithmString == null
- || Algorithm.valueOf(algorithmString.toUpperCase(Locale.ROOT)) ==
null) {
Review Comment:
We need to be careful with errorprone updates. See
https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle#L68
we want to make sure we list and explicitly enable/disable checks. Just
upgrading means we aren't going to handle all the checks we may not want to run
since they are either covered by other tools (ie: forbidden apis) or they are
not necessary for our codebase.
##########
solr/core/src/test/org/apache/solr/handler/admin/api/UnloadCoreAPITest.java:
##########
@@ -56,7 +56,6 @@ public void setUp() throws Exception {
public void testValidUnloadCoreAPIResponse() throws Exception {
SolrJerseyResponse response = unloadCoreAPI.unloadCore(coreName,
getUnloadCoreRequestBodyObj());
assertEquals(0, response.responseHeader.status);
- assertNotNull(response.responseHeader.qTime);
Review Comment:
We need to be careful with errorprone updates. See
https://github.com/apache/solr/blob/main/gradle/validation/error-prone.gradle#L68
we want to make sure we list and explicitly enable/disable checks. Just
upgrading means we aren't going to handle all the checks we may not want to run
since they are either covered by other tools (ie: forbidden apis) or they are
not necessary for our codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
