malliaridis commented on code in PR #2706:
URL: https://github.com/apache/solr/pull/2706#discussion_r1836145111
##########
solr/core/src/test/org/apache/solr/handler/admin/IndexSizeEstimatorTest.java:
##########
@@ -227,8 +227,9 @@ public void testIntegration() throws Exception {
(k, v) -> {
double size = fromHumanReadableUnits((String) v);
double sampledSize = fromHumanReadableUnits((String)
sampledFieldsBySize.get(k));
- assertNotNull(
Review Comment:
According to error-prone:
> error: [ImpossibleNullComparison] This value cannot be null, and comparing
it to null may be misleading.
This is because primitive data types have always a default value. Resolving
this to focus on the root discussion.
##########
solr/core/src/test/org/apache/solr/handler/admin/api/ReloadCoreAPITest.java:
##########
@@ -57,7 +57,6 @@ public void setUp() throws Exception {
public void testValidReloadCoreAPIResponse() throws Exception {
SolrJerseyResponse response = reloadCoreAPI.reloadCore(coreName, new
ReloadCoreRequestBody());
assertEquals(0, response.responseHeader.status);
- assertNotNull(response.responseHeader.qTime);
Review Comment:
According to error-prone:
> error: [ImpossibleNullComparison] This value cannot be null, and comparing
it to null may be misleading.
This is because primitive data types have always a default value. Resolving
this to focus on the root discussion.
##########
solr/core/src/test/org/apache/solr/handler/admin/api/UnloadCoreAPITest.java:
##########
@@ -56,7 +56,6 @@ public void setUp() throws Exception {
public void testValidUnloadCoreAPIResponse() throws Exception {
SolrJerseyResponse response = unloadCoreAPI.unloadCore(coreName,
getUnloadCoreRequestBodyObj());
assertEquals(0, response.responseHeader.status);
- assertNotNull(response.responseHeader.qTime);
Review Comment:
According to error-prone:
> error: [ImpossibleNullComparison] This value cannot be null, and comparing
it to null may be misleading.
This is because primitive data types have always a default value. Resolving
this to focus on the root discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
