Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-20 Thread via GitHub
janhoy merged PR #2345: URL: https://github.com/apache/solr/pull/2345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-19 Thread via GitHub
janhoy commented on PR #2345: URL: https://github.com/apache/solr/pull/2345#issuecomment-2007278990 Thanks for review. Will merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-19 Thread via GitHub
janhoy commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1530416388 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for co

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-19 Thread via GitHub
dsmiley commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1530372883 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for c

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-19 Thread via GitHub
janhoy commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1530311257 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for co

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-19 Thread via GitHub
janhoy commented on PR #2345: URL: https://github.com/apache/solr/pull/2345#issuecomment-2007053399 > Both Krb5HttpClientBuilder and PreemptiveBasicAuthClientBuilderFactory ought to lose their deprecated status. You marked them as such but these classes support Apache HttpClient & Jetty Htt

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-19 Thread via GitHub
janhoy commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1530237610 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for co

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-15 Thread via GitHub
dsmiley commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1527007538 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for c

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-15 Thread via GitHub
janhoy commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1526091215 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for co

Re: [PR] SOLR-17201 Make Http2SolrClients not experimental [solr]

2024-03-14 Thread via GitHub
janhoy commented on code in PR #2345: URL: https://github.com/apache/solr/pull/2345#discussion_r1524517935 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java: ## @@ -19,10 +19,7 @@ import java.io.Closeable; /** - * Factory interface for co