janhoy commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1530311257
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##########
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for configuring {@linkplain SolrHttpClientBuilder}. This
relies on the internal
- * HttpClient implementation and is subject to change.
- *
- * @lucene.experimental
+ * Factory interface for configuring {@linkplain SolrHttpClientBuilder}.
Review Comment:
`HttpClientBuilderFactory` is used in `Http2SolrClient.Builder` if sysprop
`solr.httpclient.builder.factory` is defined, so it needs to be in solrj as a
compile-time dependency. And since this one class references both apache http
and jetty http clients, it cannot be split cleanly :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
