dsmiley commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1527007538
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##########
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for configuring {@linkplain SolrHttpClientBuilder}. This
relies on the internal
- * HttpClient implementation and is subject to change.
- *
- * @lucene.experimental
+ * Factory interface for configuring {@linkplain SolrHttpClientBuilder}.
Review Comment:
Firstly; IMO `HttpClientBuilderFactory` and `SolrHttpClientBuilder` ought
not to be in SolrJ because they are only used for inter-node communication
within Solr. It's a distraction for our users to see stuff like that in SolrJ.
Indeed `HttpClientBuilderFactory` will change so keeping experimental there
is right. An aside: I'd rather see us do the inverse of "lucene.experimental"
-- have "solr.stable". If "solr.stable" is absent from a class; watch out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
