janhoy commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1524517935
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##########
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for configuring {@linkplain SolrHttpClientBuilder}. This
relies on the internal
- * HttpClient implementation and is subject to change.
- *
- * @lucene.experimental
+ * Factory interface for configuring {@linkplain SolrHttpClientBuilder}.
Review Comment:
I'm confused by this class claiming to be a factory for Apache HTTP client,
but also has a `setup` method with `Http2SolrClient` as argument. Can anyone
clarify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
