gerlowskija commented on PR #3238:
URL: https://github.com/apache/solr/pull/3238#issuecomment-2827244538
Thanks for catching this @HoustonPutman; I've got a fix I'll commit shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jkmuriithi commented on PR #3238:
URL: https://github.com/apache/solr/pull/3238#issuecomment-2819080052
> I think this broke the nightly test
`TestTlogReplica.testRebalanceLeaders()`:
>
> ```
> Error 404 Can not find:
/solr/tlog_replica_test_rebalance_leaders_shard1_replica_t3/adm
HoustonPutman commented on PR #3238:
URL: https://github.com/apache/solr/pull/3238#issuecomment-2819025088
I think this broke the nightly test `TestTlogReplica.testRebalanceLeaders()`:
```
Error 404 Can not find:
/solr/tlog_replica_test_rebalance_leaders_shard1_replica_t3/admin/col
gerlowskija merged PR #3238:
URL: https://github.com/apache/solr/pull/3238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2048844469
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1045,12 +1048,11 @@ protected NamedList sendRequest(SolrRequest
request, List in
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047753765
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/scraper/SolrScraper.java:
##
@@ -130,29 +134,35 @@ protected MetricSamples request(SolrClient client,
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047713433
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java:
##
@@ -666,11 +669,13 @@ public void testNonRetryableRequests() throws Exception {
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047689209
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -479,8 +485,9 @@ void setPropWithStandardRequest(Slice slice, Replica rep,
String prop)
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047754065
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -445,10 +449,12 @@ private void rebalancePropUsingStandardRequest(String
prop)
if (p
gerlowskija commented on PR #3238:
URL: https://github.com/apache/solr/pull/3238#issuecomment-2810718828
Hoping to move this along a bit, I've pushed some fixes to address some of
@dsmiley 's smaller style comments.
I still have a few more to go, and then will need to re-test, etc. B
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047697653
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/scraper/SolrScraper.java:
##
@@ -130,29 +134,35 @@ protected MetricSamples request(SolrClient client,
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047712486
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java:
##
@@ -730,11 +733,14 @@ public void testNonRetryableRequests() throws Exceptio
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047711676
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -138,8 +136,9 @@ public Set getUrlParamNames() {
public CompletableFuture req
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047698897
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##
@@ -1001,25 +999,30 @@ protected NamedList sendRequest(SolrRequest
request, List inp
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2040234407
##
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##
@@ -445,10 +449,12 @@ private void rebalancePropUsingStandardRequest(String
prop)
if (prop.
jkmuriithi commented on PR #3238:
URL: https://github.com/apache/solr/pull/3238#issuecomment-2795076015
Think the changes should be good now. I went through and changed problematic
tests, and I fixed the routing logic issues with ADMIN requests by adding a
check for `requiresCollection`.
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2032402387
##
solr/core/src/test/org/apache/solr/security/BasicAuthIntegrationTest.java:
##
@@ -142,13 +142,14 @@ public void testBasicAuth() throws Exception {
.bui
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2006610968
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryPa
dsmiley commented on PR #3238:
URL: https://github.com/apache/solr/pull/3238#issuecomment-2760234752
Please let us know when it's believed this PR is ready for reviewers again
(feedback has been addressed). I'm looking forward to this nice change!
--
This is an automated message from the
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2001372713
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -210,6 +236,16 @@ public boolean requiresCollection() {
return false;
}
+ /**
+
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2001444583
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/GenericSolrRequest.java:
##
@@ -50,7 +50,7 @@ public GenericSolrRequest(METHOD m, String path) {
* @par
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2001636812
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -210,6 +236,16 @@ public boolean requiresCollection() {
return false;
}
+ /**
+ *
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2001404933
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = que
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2001458019
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2001166122
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/schema/AbstractSchemaRequest.java:
##
@@ -30,17 +30,12 @@ public AbstractSchemaRequest(METHOD m, String path) {
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999402882
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999394354
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999351627
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryPa
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999350676
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryPa
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999342437
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryPa
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1999136119
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997661934
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -210,6 +236,16 @@ public boolean requiresCollection() {
return false;
}
+ /**
+ *
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997243850
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +193,21 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryPa
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997244468
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java:
##
@@ -38,7 +38,8 @@ public class SolrPing extends
CollectionRequiringSolrRequest {
/** Cr
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997236700
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -130,9 +130,14 @@ public String getBasicAuthPassword() {
//
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997236700
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -130,9 +130,14 @@ public String getBasicAuthPassword() {
//
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1996350108
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1996349605
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1994350312
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/DirectXmlRequest.java:
##
@@ -55,8 +55,13 @@ public SolrParams getParams() {
}
@Override
- public Stri
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1994346969
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/DelegationTokenRequest.java:
##
@@ -84,8 +84,8 @@ public DelegationTokenResponse.Get createResponse(SolrClient
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1994348390
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/DirectXmlRequest.java:
##
@@ -55,8 +55,13 @@ public SolrParams getParams() {
}
@Override
- public Stri
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1994305927
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -210,6 +236,16 @@ public boolean requiresCollection() {
return false;
}
+ /**
+ *
gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1991496264
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##
@@ -139,7 +137,8 @@ public CompletableFuture requestAsync(Req req) {
Completab
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1987459862
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
jkmuriithi commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1987458954
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = quer
kotman12 commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1985801827
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java:
##
@@ -53,8 +53,9 @@ public ModifiableSolrParams getParams() {
}
@Override
- public St
kotman12 commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1985801827
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java:
##
@@ -53,8 +53,9 @@ public ModifiableSolrParams getParams() {
}
@Override
- public St
kotman12 commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1985801827
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrPing.java:
##
@@ -53,8 +53,9 @@ public ModifiableSolrParams getParams() {
}
@Override
- public St
dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1985660911
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -210,6 +236,16 @@ public boolean requiresCollection() {
return false;
}
+ /**
+ *
kotman12 commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1982512886
##
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##
@@ -185,8 +188,31 @@ public void setQueryParams(Set queryParams) {
this.queryParams = queryP
jkmuriithi opened a new pull request, #3238:
URL: https://github.com/apache/solr/pull/3238
https://issues.apache.org/jira/browse/SOLR-17043
# Description
Currently, some SolrClient implementations (especially our "load-balancing"
and "cloud" clients) do pattern-matching
51 matches
Mail list logo
