dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997236700
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -130,9 +130,14 @@ public String getBasicAuthPassword() {
// ---------------------------------------------------------
// ---------------------------------------------------------
- public SolrRequest(METHOD m, String path) {
+ public SolrRequest(METHOD m, String path, SolrRequestType defaultType) {
this.method = m;
this.path = path;
+ this.defaultType = defaultType;
+ }
+
+ public SolrRequest(METHOD m, String path) {
Review Comment:
The request type here would then be subtle/hidden at the caller site. I
think the caller of SolrRequest's constructor should be explicit about this,
just as they are explicit about the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
