dsmiley commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r1997236700
##########
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java:
##########
@@ -130,9 +130,14 @@ public String getBasicAuthPassword() {
// ---------------------------------------------------------
// ---------------------------------------------------------
- public SolrRequest(METHOD m, String path) {
+ public SolrRequest(METHOD m, String path, SolrRequestType defaultType) {
this.method = m;
this.path = path;
+ this.defaultType = defaultType;
+ }
+
+ public SolrRequest(METHOD m, String path) {
Review Comment:
The request type here would then be subtle/hidden at the caller site. I
think the caller of SolrRequest's constructor should be explicit about this.
##########
solr/solrj/src/resources/java-template/api.mustache:
##########
@@ -218,12 +219,6 @@ public class {{classname}} {
}
{{/bodyParam}}
- // TODO Hardcode this for now, but in reality we'll want to parse
this out of the Operation data somehow
Review Comment:
you removed this comment but isn't it still relevant?
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionRequiringSolrRequest.java:
##########
@@ -22,6 +22,10 @@
/** Parent {@link SolrRequest} class that requires a target collection or
core. */
public abstract class CollectionRequiringSolrRequest<T extends SolrResponse>
extends SolrRequest<T> {
+ public CollectionRequiringSolrRequest(METHOD m, String path, SolrRequestType
defaultType) {
Review Comment:
why use the word "default" in "defaultType? why not just "requestType"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
