github-actions[bot] commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2605986155
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2375471479
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity or converting it to draft will remove the stale label. To attract
more reviewers, please t
cpoerschke commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2253034480
> @cpoerschke see the parent JIRA issue for the real state of this
controvertial PR
Thanks for the pointer! It inspired me to do some #2597 scribbling.
--
This is an automated me
dsmiley commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2246125113
@cpoerschke see the parent JIRA issue for the real state of this
controvertial PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688607183
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688454713
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or m
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688453058
##
solr/core/src/java/org/apache/solr/search/combining/CombineQParserPlugin.java:
##
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688438487
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1688437190
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1643463278
##
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##
@@ -241,13 +243,16 @@ public static void processParams(
if (queriesJsonObj instanceof Ma
alessandrobenedetti commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2174445957
> I did the work of migrating to a QParser but don't have permissions to
push to your PR branch.
>
> Beware, I'm reverting most/all of the files that you modified of existi
dsmiley commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2171937408
I did the work of migrating to a QParser but don't have permissions to push
to your PR branch.
Beware, I'm reverting most/all of the files that you modified of existing
Solr source
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632230094
##
solr/solrj/src/java/org/apache/solr/common/params/CombinerParams.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632229605
##
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##
@@ -173,22 +175,51 @@ public void prepare(ResponseBuilder rb) throws
IOExcepti
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632229302
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1632229327
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1630219623
##
solr/core/src/java/org/apache/solr/search/combining/QueriesCombiner.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1630193292
##
solr/core/src/test/org/apache/solr/handler/component/DebugComponentTest.java:
##
@@ -52,7 +64,7 @@ public void testBasicInterface() {
"//str[@name=
alessandrobenedetti commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2153348715
> I should have spent just another 10 minutes reading this to understand
what's going on; I understand it better now. I had overlooked the query loop. I
don't think a new Query w
dsmiley commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2153266206
Want to quickly respond to this:
> a Lucene contribution to create a new query
No! The Lucene project is not the only place where subclasses of Query
classes exist ;-)
I'm l
alessandrobenedetti commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2153161526
> I haven't looked at this in detail but I'm wondering could we instead have
a single 'q' query parser, that is itself a "query combiner" of its children
clauses? Ultimately this
dsmiley commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1629951486
##
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##
@@ -241,13 +243,16 @@ public static void processParams(
if (queriesJsonObj instanceof Ma
renatoh commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1624657341
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
renatoh commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1623870400
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
renatoh commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1624657341
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
alessandrobenedetti commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1624531316
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
renatoh commented on code in PR #2489:
URL: https://github.com/apache/solr/pull/2489#discussion_r1623870400
##
solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java:
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
alessandrobenedetti commented on PR #2489:
URL: https://github.com/apache/solr/pull/2489#issuecomment-2142359815
As of today the solution is clean enough to be reviewed and tests are green.
The usage is intuitive and it should cover many use cases.
Pending activities:
- add a new doc
alessandrobenedetti opened a new pull request, #2489:
URL: https://github.com/apache/solr/pull/2489
https://issues.apache.org/jira/browse/SOLR-17319
# Description
Reciprocal Rank Fusion (RRF) is an algorithm that takes in input multiple
ranked lists to produce a unified result
29 matches
Mail list logo
