alessandrobenedetti commented on PR #2489: URL: https://github.com/apache/solr/pull/2489#issuecomment-2153348715
> I should have spent just another 10 minutes reading this to understand what's going on; I understand it better now. I had overlooked the query loop. I don't think a new Query would be that helpul for this use-case after-all. Even if one were to exist, _somewhere_ there would be code to detect it and loop it so _where_ would that go... either QueryComponent or SolrIndexSearcher which is another complexity minefield of greater magnitude. It's tempting to think of a QueryComponent subclass for this use-case (and for that matter grouping). > > BTW I like the query syntax, especially the JSON variant. > > Sorry for any distress; +1 overall. No distress David! I'm not the kind of developer that get attached to its own solutions. If there are better ways I'm always open to suggestions. I also agree in principle with proposing ideas first, before spending days inplementing them, the only reason that I don't do that often is because I am not full time on Solr contributions right now, actually I end up at the moment with limited time to do them, so I prefer to produce something that could be valuable and iterate. Having to wait for other volunteers time to discuss the idea could end up in exhausting the time I had allocated for the contrib and have to wait for the next availability window between clients. Worst case scenario we end up with a discussion and we may ignore the Pull Request. I remember at the beginning I tried query parsing and other approaches but the cleanest I got was the loop in the query component. And I absolutely agree that component is messy, so after Berlin I'll spend a bit more time polishing the changes, and if in the meantime we come up with better ideas, the better! No rush to merge, but at the same time if we get a decent consensus I would love to have this in as this feature will open many doors! Thanks for the time you already spent on this, it's always very much appreciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
