dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2139109190
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
return
github-actions[bot] commented on PR #3157:
URL: https://github.com/apache/solr/pull/3157#issuecomment-2960840232
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] closed pull request #3166: Refactor UpdateLog.LogPtr to a
record
URL: https://github.com/apache/solr/pull/3166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
github-actions[bot] commented on PR #2632:
URL: https://github.com/apache/solr/pull/2632#issuecomment-2960840368
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] closed pull request #2881: SOLR-16427: Enable error-prone
ClassInitializationDeadlock rule
URL: https://github.com/apache/solr/pull/2881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #3166:
URL: https://github.com/apache/solr/pull/3166#issuecomment-2960840176
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] commented on PR #3251:
URL: https://github.com/apache/solr/pull/3251#issuecomment-2960840061
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2881:
URL: https://github.com/apache/solr/pull/2881#issuecomment-2960840335
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] commented on PR #3170:
URL: https://github.com/apache/solr/pull/3170#issuecomment-2960840148
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
github-actions[bot] closed pull request #3170: Backport chore(deps): update
dependency org.owasp.dependencycheck to v12 (#3138)
URL: https://github.com/apache/solr/pull/3170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
HoustonPutman merged PR #3375:
URL: https://github.com/apache/solr/pull/3375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
psalagnac opened a new pull request, #3382:
URL: https://github.com/apache/solr/pull/3382
https://issues.apache.org/jira/browse/SOLR-1
# Description
This fixes a minor memory leak. I don't think it can have an actual impact
on heap, but the fix is trivial and not risky.
HoustonPutman merged PR #3334:
URL: https://github.com/apache/solr/pull/3334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
HoustonPutman merged PR #3341:
URL: https://github.com/apache/solr/pull/3341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
HoustonPutman opened a new pull request, #1657:
URL: https://github.com/apache/solr/pull/1657
I can create a JIRA for this if we decide to move forward.
Basically I had an issue when debugging a new CollectionsAPI command, that
reading the output of a 500 error was very difficult sinc
HoustonPutman opened a new pull request, #2161:
URL: https://github.com/apache/solr/pull/2161
[SOLR-17105](https://issues.apache.org/jira/browse/SOLR-17105) &
[SOLR-17366](https://issues.apache.org/jira/browse/SOLR-17366)
--
This is an automated message from the Apache Git Service.
To res
HoustonPutman opened a new pull request, #2154:
URL: https://github.com/apache/solr/pull/2154
https://issues.apache.org/jira/browse/SOLR-17104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
HoustonPutman commented on PR #1921:
URL: https://github.com/apache/solr/pull/1921#issuecomment-2959900913
Closing this in favor of https://github.com/apache/solr/pull/3334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
HoustonPutman closed pull request #1921: SOLR-16951: Cache client pkiAuth
headers for a second
URL: https://github.com/apache/solr/pull/1921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
epugh commented on PR #3312:
URL: https://github.com/apache/solr/pull/3312#issuecomment-2959835025
Thanks for letting oking at this! I had tuna but out of steam on it but
will try and pick it up again and get this batch of changes in. Definitely 10x
change.
--
This is an automated mess
mlbiscoc commented on PR #3379:
URL: https://github.com/apache/solr/pull/3379#issuecomment-2959800308
Any other comments? Will merge in the next few days otherwise and open the
next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
HoustonPutman merged PR #3381:
URL: https://github.com/apache/solr/pull/3381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
HoustonPutman opened a new pull request, #3381:
URL: https://github.com/apache/solr/pull/3381
https://issues.apache.org/jira/browse/SOLR-17678
The functionality was already added in
https://github.com/apache/solr/pull/3222, but this is making the following
changes before any release
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2136046774
##
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##
@@ -50,6 +51,7 @@
public class SolrReturnFields extends ReturnFields {
// Special Field Ke
dsmiley commented on PR #3305:
URL: https://github.com/apache/solr/pull/3305#issuecomment-2955782366
Let us know if you need help/guidance on seeing this through to completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
janhoy commented on code in PR #3312:
URL: https://github.com/apache/solr/pull/3312#discussion_r2135688338
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -1766,7 +1766,7 @@ private SolrCore createFromDescriptor(
// this mostly happens when the core
janhoy commented on code in PR #3312:
URL: https://github.com/apache/solr/pull/3312#discussion_r2135670969
##
solr/solrj/src/java/org/apache/solr/common/util/EnvUtils.java:
##
@@ -32,28 +33,47 @@
import java.util.concurrent.ConcurrentHashMap;
import java.util.stream.Collectors
github-actions[bot] commented on PR #3312:
URL: https://github.com/apache/solr/pull/3312#issuecomment-2954342106
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
janhoy commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2134845126
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -465,6 +480,39 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
github-actions[bot] commented on PR #2963:
URL: https://github.com/apache/solr/pull/2963#issuecomment-2953256082
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
Joshuaariolu opened a new issue, #789:
URL: https://github.com/apache/solr-operator/issues/789
I'm running Apache Solr 9.8.0 on Amazon EKS using Helm. I want to modify the
security-related HTTP headers that Solr sets—specifically, I want to remove
'unsafe-inline' from the Content-Security-P
mlbiscoc commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2132890849
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -423,6 +433,11 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
dsmiley commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2132810513
##
solr/core/src/java/org/apache/solr/core/OpenTelemetryConfigurator.java:
##
@@ -46,26 +50,53 @@ public abstract class TracerConfigurator implements
NamedListInitialized
psalagnac merged PR #3350:
URL: https://github.com/apache/solr/pull/3350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
mlbiscoc commented on PR #3379:
URL: https://github.com/apache/solr/pull/3379#issuecomment-2949660931
Going to bump this if any one interesting in looking? I have another PR
almost ready that implements the foundation for working OTEL metrics.
--
This is an automated message from the Apac
dsmiley merged PR #3380:
URL: https://github.com/apache/solr/pull/3380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on PR #2655:
URL: https://github.com/apache/solr/pull/2655#issuecomment-2947341362
Probably I totally forgot about this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2130726121
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
return
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2130657407
##
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java:
##
@@ -205,19 +205,13 @@ private static Http2SolrClient.Builder
newHttp2SolrClientB
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2130676326
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
return
HoustonPutman commented on PR #2655:
URL: https://github.com/apache/solr/pull/2655#issuecomment-2946576965
@risdenk should we move forward with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2130373395
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -129,6 +126,12 @@ protected Http2SolrClient(String serverBaseUrl, Builder
builder) {
kotman12 commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2129982207
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
retur
kotman12 commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2129982207
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
retur
kotman12 commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2129982207
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
retur
kotman12 commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2129941025
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java:
##
@@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) {
retur
dsmiley commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2129848607
##
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##
@@ -50,6 +51,7 @@
public class SolrReturnFields extends ReturnFields {
// Special Field Keys
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2129734839
##
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##
@@ -50,6 +51,7 @@
public class SolrReturnFields extends ReturnFields {
// Special Field Ke
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2129733214
##
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##
@@ -50,6 +51,7 @@
public class SolrReturnFields extends ReturnFields {
// Special Field Ke
dsmiley commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2945417091
I mispoke/misunderstood... thinking this would work for a `fl=aDvField` when
no, that's handled by `SolrDocumentFetcher`
`org.apache.solr.search.SolrDocumentFetcher#decorateDocValueFields`.
yurkor commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2945085396
@dsmiley Done. Will keep in mind - no force pushes) Usually it even worse -
with single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
dsmiley commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2944125812
OMG I'm slipping... you already have a CHANGES.txt. Nonetheless my feedback
shows a massive difference between the actual code change (what you wrote about
there) and how users understand/e
dsmiley commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2944112030
Great!
(BTW, stop force-pushing to PRs. It resets the GH review state, therefore,
as a reviewer, I can't as easily clearly see your changes from one change to
the next).
CHANGES.txt:
dsmiley commented on code in PR #3361:
URL: https://github.com/apache/solr/pull/3361#discussion_r2127845663
##
solr/modules/tika/src/java/org/apache/solr/handler/tika/TikaServerDocumentLoader.java:
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
dsmiley commented on code in PR #3380:
URL: https://github.com/apache/solr/pull/3380#discussion_r2127833365
##
solr/core/src/java/org/apache/solr/response/transform/ValueSourceAugmenter.java:
##
@@ -61,32 +67,66 @@ public void setContext(ResultContext context) {
readerCon
dsmiley commented on code in PR #3380:
URL: https://github.com/apache/solr/pull/3380#discussion_r2127571321
##
solr/core/src/java/org/apache/solr/response/transform/ValueSourceAugmenter.java:
##
@@ -38,14 +40,23 @@
* @since solr 4.0
*/
public class ValueSourceAugmenter exte
yurkor commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2940917301
@dsmiley added use of localParams
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
psalagnac commented on PR #3350:
URL: https://github.com/apache/solr/pull/3350#issuecomment-2939220516
Going to merge this PR this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2125527519
##
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##
@@ -862,7 +862,6 @@ private void doCompatCheck(BiConsumer
consumer) {
new Http2SolrClient.Build
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2096407656
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java:
##
@@ -256,7 +256,7 @@ void sendUpdateStream() throws Exception {
dsmiley commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2125495095
##
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##
@@ -50,6 +51,7 @@
public class SolrReturnFields extends ReturnFields {
// Special Field Keys
github-actions[bot] commented on PR #3162:
URL: https://github.com/apache/solr/pull/3162#issuecomment-2937780497
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
HoustonPutman commented on PR #3222:
URL: https://github.com/apache/solr/pull/3222#issuecomment-2937175581
> I wish I reviewed this earlier... feel free to tag me on geeky Solr
internals... there are only a few of us that know this stuff
Sorry have been vacationing and busy. Happy to
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2124911514
##
solr/core/src/java/org/apache/solr/search/SolrReturnFields.java:
##
@@ -50,6 +51,7 @@
public class SolrReturnFields extends ReturnFields {
// Special Field Ke
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2124890606
##
solr/solrj/src/java/org/apache/solr/common/SolrDocument.java:
##
@@ -195,6 +197,19 @@ public Collection getFieldValues(String name) {
return null;
}
+
HoustonPutman commented on code in PR #3222:
URL: https://github.com/apache/solr/pull/3222#discussion_r2124888615
##
solr/core/src/java/org/apache/solr/search/DocIterator.java:
##
@@ -24,7 +24,7 @@
* The order of the documents is determined by the context in which the
DocIter
mlbiscoc merged PR #3373:
URL: https://github.com/apache/solr/pull/3373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
yurkor commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2936715567
> I like it. @devs please have a glance at it. I'm ready to merge, but
prefer the second opinion. @yurkor thank you. Would you mind to add it into
solr/CHANGES.txt 9.9.0 Optimizations ?
dsmiley closed pull request #3362: add tests to validate timeout overrides
URL: https://github.com/apache/solr/pull/3362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
lizbiella opened a new pull request, #148:
URL: https://github.com/apache/solr-site/pull/148
New Blogpost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2096415291
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1085,27 +1084,20 @@ public Builder withHttpClient(Http2SolrClient
http2SolrClient) {
dsmiley commented on PR #3362:
URL: https://github.com/apache/solr/pull/3362#issuecomment-2935047385
Thanks again; I'll incorporate this into #3357 and update that one to apply
the idle timeout at the request level
--
This is an automated message from the Apache Git Service.
To respond to
dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2123681294
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -514,7 +522,7 @@ public NamedList request(SolrRequest
solrRequest, String collection)
epugh commented on PR #2783:
URL: https://github.com/apache/solr/pull/2783#issuecomment-2931971378
I am kind of waiting for the 10x release cycle to spin up to push this
along. There are some things I would change/update in this doc if we get some
nicer ZK quorum stuff and role stuff done.
epugh opened a new pull request, #2783:
URL: https://github.com/apache/solr/pull/2783
https://issues.apache.org/jira/browse/SOLR-17492
# Description
Add recommendations of best practices for deploying Solr
# Solution
I am starting with my approach that I shared
mlbiscoc commented on PR #3373:
URL: https://github.com/apache/solr/pull/3373#issuecomment-2930849382
> I wonder why these logs are warnings. The fact that they are warnings is
probably intentionally why the exception wasn't appended.
The exception used to be appended but when doing t
mkhludnev commented on PR #3380:
URL: https://github.com/apache/solr/pull/3380#issuecomment-2929962589
I like it. @devs please have a glance. I'm ready to merge, but prefer the
second opinion.
@yurkor thank you.
Would you mind to add it into solr/CHANGES.txt 9.9.0 Optimizations ?
dsmiley merged PR #3355:
URL: https://github.com/apache/solr/pull/3355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #3373:
URL: https://github.com/apache/solr/pull/3373#issuecomment-2928624158
This is too minor to warrant a CHANGES.txt -- see
https://cwiki.apache.org/confluence/display/SOLR/Commit+Process+Guidelines#CommitProcessGuidelines-ExceptionsforMinorChanges
I wonde
github-actions[bot] closed pull request #2783: SOLR-17492: Introduce
recommendations of WAYS of running Solr from small to massive
URL: https://github.com/apache/solr/pull/2783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on PR #2783:
URL: https://github.com/apache/solr/pull/2783#issuecomment-2928154949
This PR is now closed due to 60 days of inactivity after being marked as
stale. Re-opening this PR is still possible, in which case it will be marked
as active again.
--
This
janhoy commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2118268512
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -465,6 +480,19 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
yurkor opened a new pull request, #3380:
URL: https://github.com/apache/solr/pull/3380
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Ple
mlbiscoc commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2116805755
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -465,6 +480,39 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
mlbiscoc commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2116269332
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -465,6 +480,19 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
janhoy commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2115601188
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -465,6 +480,19 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
mlbiscoc commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2114832472
##
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##
@@ -423,6 +433,11 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
mlbiscoc opened a new pull request, #3379:
URL: https://github.com/apache/solr/pull/3379
This refactors how the Global Open Telemetry instance was set and adds
`opentelemetry-exporter-prometheus` and `opentelemetry.sdk` into core as a
dependency. `opentelemetry-exporter-prometheus` is neede
dsmiley commented on code in PR #3355:
URL: https://github.com/apache/solr/pull/3355#discussion_r2114388302
##
solr/core/src/test/org/apache/solr/search/facet/SpatialHeatmapFacetsTest.java:
##
@@ -438,8 +436,7 @@ public void testJsonFacets() throws Exception {
epugh merged PR #3378:
URL: https://github.com/apache/solr/pull/3378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #3378:
URL: https://github.com/apache/solr/pull/3378#issuecomment-2919665135
Can you add a changes entry? And then when the tests pass I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rahulgoswami commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114128683
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOExc
epugh commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114086764
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOException
rahulgoswami commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOExc
rahulgoswami commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOExc
rahulgoswami commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOExc
rahulgoswami commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOExc
rahulgoswami commented on code in PR #3378:
URL: https://github.com/apache/solr/pull/3378#discussion_r2114054937
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -102,7 +102,7 @@ public int execute(org.apache.commons.exec.CommandLine cmd)
throws IOExc
dsmiley commented on code in PR #3355:
URL: https://github.com/apache/solr/pull/3355#discussion_r2113950364
##
solr/core/src/test/org/apache/solr/search/facet/SpatialHeatmapFacetsTest.java:
##
@@ -441,11 +438,11 @@ public void testJsonFacets() throws Exception {
dsmiley commented on PR #3356:
URL: https://github.com/apache/solr/pull/3356#issuecomment-2919383276
I quickly looked at Jetty HttpClient and there's no request timeout there.
It's on the Jetty Request.
--
This is an automated message from the Apache Git Service.
To respond to the messag
1 - 100 of 10068 matches
Mail list logo
