mlbiscoc commented on code in PR #3379:
URL: https://github.com/apache/solr/pull/3379#discussion_r2116269332
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -465,6 +480,19 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
new SolrNamedThreadFactory("IndexFingerprintPool"));
}
+ private void initializeOpenTelemetrySdk() {
+ PluginInfo info = cfg.getTracerConfiguratorPluginInfo();
+
+ if (OpenTelemetryConfigurator.shouldAutoConfigOTEL()) {
+ OpenTelemetryConfigurator.autoConfigureOpenTelemetrySdk(loader);
+ } else if (info != null && info.isEnabled()) {
+ OpenTelemetryConfigurator.loadOpenTelemetrySdk(loader,
cfg.getTracerConfiguratorPluginInfo());
Review Comment:
Unintended change by me when I was moving it. Good catch. I switched it back
around and added a javadoc that explains how it prioritizes (custom ->
autoconfigure -> default configuration).
And the naming was probably bad. I changed `load` to
`configureCustomOpenTelemetrySdk`. Maybe this is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
