mlbiscoc opened a new pull request, #3379: URL: https://github.com/apache/solr/pull/3379
This refactors how the Global Open Telemetry instance was set and adds `opentelemetry-exporter-prometheus` and `opentelemetry.sdk` into core as a dependency. `opentelemetry-exporter-prometheus` is needed as it gives us a MetricReader to collect metrics in Prometheus format that can be exposed to the /admin/metrics endpoint. Initially, `GlobalOpenTelemetry` was only set for accepting tracing and spans but was not dynamic enough to configure it for metrics or even logs down the line. I renamed `TracerConfigurator` to `OpenTelemetryConfigurator` accordingly. I also moved the initialization to of setting the `GlobalOpenTelemetry` to the constructor of `coreContainer` so it is called as early as possible. It was initially inside of `loadInternal()` which threw an exception for metrics because there are metrics being recorded on loading of coreContainer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
