dsmiley commented on code in PR #3357:
URL: https://github.com/apache/solr/pull/3357#discussion_r2096415291
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1085,27 +1084,20 @@ public Builder withHttpClient(Http2SolrClient
http2SolrClient) {
if (this.basicAuthAuthorizationStr == null) {
this.basicAuthAuthorizationStr =
http2SolrClient.basicAuthAuthorizationStr;
}
- if (this.followRedirects == null) {
- this.followRedirects = http2SolrClient.httpClient.isFollowRedirects();
- }
- if (this.idleTimeoutMillis == null) {
- this.idleTimeoutMillis = http2SolrClient.idleTimeoutMillis;
+ if (this.requestTimeoutMillis == null) {
+ this.requestTimeoutMillis = http2SolrClient.requestTimeoutMillis;
Review Comment:
only the request timeout is owned by our SolrClient and *not* HttpClient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
