dsmiley commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2700120656
> But if SMO is backed by a LinkedHashMap, wouldn't then these changes
become obsolete? What is the point of unmarshalling to SMO (backed by a
LinkedHashMap) instead of a directly to a Linke
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1980520237
##
solr/core/src/java/org/apache/solr/cli/CLIUtils.java:
##
@@ -226,6 +226,11 @@ public static String getZkHost(CommandLine cli) throws
Exception {
return zkHost;
renatoh commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2700070953
> I have a some doubts that gnaw at me pertaining to the performance risks
of O(1) maps suddenly becoming O(N). It doesn't sit well with me. You had
suggested changing SimpleOrderedMap to be
dsmiley commented on code in PR #3235:
URL: https://github.com/apache/solr/pull/3235#discussion_r1980622308
##
solr/solrj/src/java/org/apache/solr/common/params/SolrParams.java:
##
@@ -69,18 +69,16 @@ public String get(String param, String def) {
@Override
public void wr
janhoy commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2699447199
Thanks for testing further. Turns out many CLI commands document that
`ZK_HOST` can be used in place of `--zk-host`, but they never attempt to read
the environment. What `CLIUtils
janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1980521378
##
solr/core/src/test/org/apache/solr/cli/ZkSubcommandsTest.java:
##
@@ -507,9 +507,10 @@ public void testGetFile() throws Exception {
Path file =
tmpDir.reso
[
https://issues.apache.org/jira/browse/SOLR-17690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17690:
--
Labels: pull-request-available (was: )
> Solr CLI tools like zk cp does not read ZK_HOST
> ---
janhoy opened a new pull request, #3240:
URL: https://github.com/apache/solr/pull/3240
https://issues.apache.org/jira/browse/SOLR-17690
Fix for https://github.com/apache/solr-operator/issues/762
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-17690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17690:
---
Fix Version/s: 9.8.1
> Solr CLI tools like zk cp does not read ZK_HOST
>
Jan Høydahl created SOLR-17690:
--
Summary: Solr CLI tools like zk cp does not read ZK_HOST
Key: SOLR-17690
URL: https://issues.apache.org/jira/browse/SOLR-17690
Project: Solr
Issue Type: Bug
dsmiley commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1979525750
##
solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java:
##
@@ -124,6 +124,9 @@ public class JavaBinCodec implements PushWriter {
private boolean alreadyUn
github-actions[bot] commented on PR #2825:
URL: https://github.com/apache/solr/pull/2825#issuecomment-2699303447
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
github-actions[bot] commented on PR #2685:
URL: https://github.com/apache/solr/pull/2685#issuecomment-2699303511
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
umut-sar commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2699066174
@madrob Yes, It worked without additional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
madrob commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2699055852
Does the new java file get compiled and tested by our existing grade
configuration without any additional changes? That's super cool.
--
This is an automated message from the Apache Git Ser
umut-sar commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2699050867
Almost all code / command snippets in the reference guide are hard coded,
expect the one SolrJ class. I think we could use BATS for simple shell commands
but suggest
[Testcontainers](https
epugh commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2698978837
For example, I wonder if we have complex shell script commands that we could
test with BATS, and then do the same cut/n/paste into the Ref Guide?
--
This is an automated message from the Apa
epugh commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2698977316
Thanks, running the tests and if they pass will merge! This is a nice
improvement..Feel free to tag me on any other PR's you come up with. I
wonder if there are other places in the ref
umut-sar commented on code in PR #3237:
URL: https://github.com/apache/solr/pull/3237#discussion_r1980257399
##
solr/solr-ref-guide/modules/deployment-guide/examples/UsingPingRefGuideExamplesTest.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
umut-sar commented on code in PR #3237:
URL: https://github.com/apache/solr/pull/3237#discussion_r1980257066
##
solr/solr-ref-guide/modules/deployment-guide/examples/UsingPingRefGuideExamplesTest.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
dsmiley opened a new pull request, #3239:
URL: https://github.com/apache/solr/pull/3239
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on code in PR #3183:
URL: https://github.com/apache/solr/pull/3183#discussion_r1980230626
##
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##
@@ -67,6 +67,12 @@ It is always strongly recommended that you fully reindex
your docum
renatoh commented on code in PR #3235:
URL: https://github.com/apache/solr/pull/3235#discussion_r1980187064
##
solr/solrj/src/java/org/apache/solr/common/params/SolrParams.java:
##
@@ -69,18 +69,16 @@ public String get(String param, String def) {
@Override
public void wr
renatoh commented on PR #3163:
URL: https://github.com/apache/solr/pull/3163#issuecomment-2698840306
@dsmiley All tests are passing now, are we able to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
epugh commented on PR #3236:
URL: https://github.com/apache/solr/pull/3236#issuecomment-2698775417
Thanks for jumping on this @stillalex and looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
epugh commented on code in PR #3236:
URL: https://github.com/apache/solr/pull/3236#discussion_r1980146287
##
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java:
##
@@ -148,7 +148,7 @@ public static void main(String[] args) {
.arg
epugh closed pull request #3237: SOLR-17684: SolrJ Reference Guide (Ping) -
Incorrect Status Retrieval
URL: https://github.com/apache/solr/pull/3237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
epugh commented on PR #3212:
URL: https://github.com/apache/solr/pull/3212#issuecomment-2698741995
I was kind of waiting for Crave to come back to test my PR, but if that
doesn't happen in a few days will run test suite locally and then merge.
--
This is an automated message from the Apac
epugh commented on code in PR #3237:
URL: https://github.com/apache/solr/pull/3237#discussion_r1980125917
##
solr/solr-ref-guide/modules/deployment-guide/examples/UsingPingRefGuideExamplesTest.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
jdgiddings commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2698732535
@janhoy I found a temporary solution. the `solr zk` command is not
respecting the ZK_HOST environment variable. I created an init container
identical to `setup-zk` but, I adde
epugh commented on PR #3237:
URL: https://github.com/apache/solr/pull/3237#issuecomment-2698731158
This looks great, however, can we slim down the test by removing the
TechProducts code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/SOLR-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932415#comment-17932415
]
Umut Saribiyik commented on SOLR-17684:
---
[~epugh] Could you please review the PR?
[
https://issues.apache.org/jira/browse/SOLR-17043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17043:
--
Labels: V2 pull-request-available (was: V2)
> Remove SolrClient path pattern matching
> --
[
https://issues.apache.org/jira/browse/SOLR-17684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17684:
--
Labels: guide monitor pingrequest pull-request-available reference solrj
(was: guide monitor p
umut-sar opened a new pull request, #3237:
URL: https://github.com/apache/solr/pull/3237
- Update ping.adoc with references from unit test.
- Add unit test to illustrate the usage of the ping response.
https://issues.apache.org/jira/browse/SOLR-17684
# Description
dsmiley commented on code in PR #3212:
URL: https://github.com/apache/solr/pull/3212#discussion_r1980093462
##
solr/core/src/java/org/apache/solr/schema/ExchangeRateProvider.java:
##
@@ -21,7 +21,7 @@
import org.apache.lucene.util.ResourceLoader;
import org.apache.solr.common.
dsmiley commented on PR #3207:
URL: https://github.com/apache/solr/pull/3207#issuecomment-2698666019
Plan to merge Friday to main; no changes.txt / JIRA. Merge commit message:
> Dead code removal in JavaBinUpdateRequestCodec.
> Compatibility: It's probable that an old SolrJ might somet
jdgiddings commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2698656591
Running the command `sh -c solr zk cp zk:/security.json
/tmp/current_security.json`, the first command in the `setup-zk` script, in an
identical init container returns:
jdgiddings commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2698560802
I ran some further tests. I added the SECURITY_JSON environment variable to
the `solrcloud-node` container and (roughly) ran the commands from `setup-zk`
and they worked! Here
jdgiddings commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2698446806
I have confirmed it is not a race condition. I spun up the zookeepers first
and then spun up the first solr node. The issue appears to lie in the command
on `setup-zk`
-
jdgiddings commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2698325052
Here is a minimal example where the bug occurs. Please excuse the Azure
stuff, we're hosting it on AKS
```yaml
apiVersion: v1
kind: Secret
metadata:
name:
[
https://issues.apache.org/jira/browse/SOLR-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932347#comment-17932347
]
Bernd Wahlen commented on SOLR-17689:
-
thank you for the quick and detailed answer. I
[
https://issues.apache.org/jira/browse/SOLR-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bernd Wahlen resolved SOLR-17689.
-
Resolution: Not A Problem
> Admin UI: Cloud -> Nodes -> Heap works only with fixed heap size
> --
[
https://issues.apache.org/jira/browse/SOLR-17638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932341#comment-17932341
]
Alex Deparvu commented on SOLR-17638:
-
put together a PR for this [https://github.com
stillalex opened a new pull request, #3236:
URL: https://github.com/apache/solr/pull/3236
https://issues.apache.org/jira/browse/SOLR-17638
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
[
https://issues.apache.org/jira/browse/SOLR-17638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17638:
--
Labels: pull-request-available (was: )
> Some CLI errors not logged when starting prometheus e
[
https://issues.apache.org/jira/browse/SOLR-17689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932317#comment-17932317
]
Jan Høydahl commented on SOLR-17689:
Hi. Seems you have configured a non-standard hea
Bernd Wahlen created SOLR-17689:
---
Summary: Admin UI: Cloud -> Nodes -> Heap works only with fixed
heap size
Key: SOLR-17689
URL: https://issues.apache.org/jira/browse/SOLR-17689
Project: Solr
janhoy commented on issue #762:
URL: https://github.com/apache/solr-operator/issues/762#issuecomment-2696664654
Can you whip together a **minimum reproduction** of this? E.g.
1. Install solr operator 0.9.0
2. Create a secret with a security.json as follows: bla bla kubectl apply
bl
49 matches
Mail list logo
