umut-sar opened a new pull request, #3237: URL: https://github.com/apache/solr/pull/3237
- Update ping.adoc with references from unit test. - Add unit test to illustrate the usage of the ping response. https://issues.apache.org/jira/browse/SOLR-17684 # Description The SolrJ Reference Guide provides incorrect examples for retrieving the ping status of a collection. https://solr.apache.org/guide/solr/9_8/deployment-guide/ping.html # Solution pingResponse.getStatus() returns the status of the ping request itself (status=0), not the collection's ping status ("OK"). Since getResponse() returns a NamedList<Object>, the value must be explicitly cast to a String or converted using .toString(). # Tests Created a new test class named: UsingPingRefGuideExamplesTest # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
