janhoy commented on code in PR #3240:
URL: https://github.com/apache/solr/pull/3240#discussion_r1980521378
##########
solr/core/src/test/org/apache/solr/cli/ZkSubcommandsTest.java:
##########
@@ -507,9 +507,10 @@ public void testGetFile() throws Exception {
Path file =
tmpDir.resolve("solrtest-getfile-" + this.getClass().getName() + "-" +
System.nanoTime());
+ // Not setting --zk-host, will fall back to sysProp 'zkHost'
String[] args =
new String[] {
- "cp", "-z", zkServer.getZkAddress(), "zk:" + getNode,
file.toAbsolutePath().toString()
+ "cp", "zk:" + getNode, file.toAbsolutePath().toString()
Review Comment:
Simple way of testing the fix. This test explicitly sets `zkHost` sysProp in
setUp, so removing `-z` shuold cause a fallback. The test
`ZkSubcommandsTest#testGetFile()` will thus fail until the fix is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
