HoustonPutman commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2623621771
> Just curious; I suppose this bug might show as an NPE?
It doesnt show at all. The thread thats running the async request fails, and
since its not in the catch, it doesnt pass t
dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1935063818
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/AbstractUpdateRequest.java:
##
@@ -21,10 +21,9 @@
import org.apache.solr.common.params.ModifiableSolrParams;
dsmiley commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2623522751
Just curious; I suppose this bug might show as an NPE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1934927357
##
solr/solrj/src/java/org/apache/solr/common/params/SolrParams.java:
##
@@ -526,4 +526,9 @@ public String toString() {
}
return sb.toString();
}
+
+ /** An
dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1934925281
##
solr/modules/cross-dc/src/java/org/apache/solr/crossdc/common/MirroredSolrRequest.java:
##
@@ -247,10 +246,10 @@ public boolean equals(final Object o) {
}
publi
dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1934921025
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/DirectXmlRequest.java:
##
@@ -20,13 +20,15 @@
import
org.apache.solr.client.solrj.request.RequestWriter.Strin
dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1934914237
##
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##
@@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader(
}
public static String
markrmiller commented on PR #3147:
URL: https://github.com/apache/solr/pull/3147#issuecomment-2623245074
Nice catch. Patch looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
madrob commented on code in PR #3146:
URL: https://github.com/apache/solr/pull/3146#discussion_r1934824591
##
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java:
##
@@ -148,12 +147,11 @@ public String lookupZKManagedSchemaPath() {
*/
public Path look
github-actions[bot] commented on PR #2783:
URL: https://github.com/apache/solr/pull/2783#issuecomment-2623202990
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
HoustonPutman opened a new pull request, #3147:
URL: https://github.com/apache/solr/pull/3147
https://issues.apache.org/jira/browse/SOLR-17637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17637:
--
Labels: pull-request-available (was: )
> HttpShardHandler can wait indefinitely when retrying
[
https://issues.apache.org/jira/browse/SOLR-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922242#comment-17922242
]
Houston Putman commented on SOLR-17637:
---
I believe this will fix a lot of the {{Tes
AndreyBozhko opened a new pull request, #3146:
URL: https://github.com/apache/solr/pull/3146
https://issues.apache.org/jira/browse/SOLR-X
# Description
EmbeddedSolrServer has a public constructor `EmbeddedSolrServer(Path
solrHome, String defaultCoreName)` - whic
Houston Putman created SOLR-17637:
-
Summary: HttpShardHandler can wait indefinitely when retrying
after certain failures
Key: SOLR-17637
URL: https://issues.apache.org/jira/browse/SOLR-17637
Project:
[
https://issues.apache.org/jira/browse/SOLR-17151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922240#comment-17922240
]
Houston Putman commented on SOLR-17151:
---
I think a small here opened up a pretty bi
AndreyBozhko commented on code in PR #3146:
URL: https://github.com/apache/solr/pull/3146#discussion_r1934788370
##
solr/core/src/test/org/apache/solr/client/solrj/embedded/TestEmbeddedSolrServerConstructors.java:
##
@@ -58,4 +63,63 @@ public void testNodeConfigConstructor() thr
mlbiscoc commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2623119702
> @mlbiscoc I should have reminded/and or run the nightly tests when I was
reviewing the path stuff.. Let's remember to do that as we continue!
Got it. Thanks @HoustonPutman for fixin
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2622942999
> have a slight concern if there's existing code relying on quirky sad
behaviors of NamedList.asShallowMap having weird/sad implementations of
`keySet`, `values`, `entrySet` because it calls
gerlowskija commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1934494649
##
solr/solrj/src/java/org/apache/solr/client/solrj/request/AbstractUpdateRequest.java:
##
@@ -21,10 +21,9 @@
import org.apache.solr.common.params.ModifiableSolrParam
madrob commented on PR #3145:
URL: https://github.com/apache/solr/pull/3145#issuecomment-2622778263
I've heard rumblings that this data is going to move away from whimsy and
onto infra-reports.a.o, so it may behoove us to wait a bit instead of switching
now and then switching again. @dfoulk
[
https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922209#comment-17922209
]
ASF subversion and git services commented on SOLR-17306:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922210#comment-17922210
]
ASF subversion and git services commented on SOLR-17548:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922202#comment-17922202
]
ASF subversion and git services commented on SOLR-17306:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922203#comment-17922203
]
ASF subversion and git services commented on SOLR-17548:
Commit 2
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2622728797
> Just needs a CHANGES.txt entry.
I've added that under Solr 9.9.0, is that correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/SOLR-17438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17438:
--
Labels: pull-request-available (was: )
> releaseWizard: remove refs to people.apache.org/home.
janhoy opened a new pull request, #3145:
URL: https://github.com/apache/solr/pull/3145
https://issues.apache.org/jira/browse/SOLR-17438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922182#comment-17922182
]
ASF subversion and git services commented on SOLR-17306:
Commit a
HoustonPutman merged PR #3142:
URL: https://github.com/apache/solr/pull/3142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
[
https://issues.apache.org/jira/browse/SOLR-17548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922183#comment-17922183
]
ASF subversion and git services commented on SOLR-17548:
Commit a
epugh commented on code in PR #3144:
URL: https://github.com/apache/solr/pull/3144#discussion_r1934338854
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -75,16 +75,9 @@ public void startReplication(boolean switchTransactionLog) {
"Solr
dsmiley commented on code in PR #3048:
URL: https://github.com/apache/solr/pull/3048#discussion_r1934300672
##
solr/solrj/src/java/org/apache/solr/common/util/NamedList.java:
##
@@ -238,6 +238,14 @@ public int indexOf(String name, int start) {
return -1;
}
+ /***
+
Christine Poerschke created SOLR-17636:
--
Summary: add BPReorderingMergePolicyFactory class
Key: SOLR-17636
URL: https://issues.apache.org/jira/browse/SOLR-17636
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-17187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922161#comment-17922161
]
Christine Poerschke commented on SOLR-17187:
https://github.com/apache/solr/p
[
https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922155#comment-17922155
]
David Smiley commented on SOLR-17379:
-
I didn't know Lucene had a special TestSecurit
cpoerschke opened a new pull request, #2641:
URL: https://github.com/apache/solr/pull/2641
https://github.com/apache/lucene/pull/12622 in Lucene 9.9 added a
`BPReorderingMergePolicy` and the changes in this PR are to make it
configurable in Solr.
TODO list:
- [ ] create JIRA issu
cpoerschke commented on PR #2316:
URL: https://github.com/apache/solr/pull/2316#issuecomment-2622171632
Opened #3144 as a continuation of this pull request here since pushing to
this PR's branch is not possible (due to org vs. individual repo fork).
--
This is an automated message from th
cpoerschke opened a new pull request, #3144:
URL: https://github.com/apache/solr/pull/3144
Continuation of @tboeghk's #2316 as a new pull request since pushing to the
PR's branch is not possible (due to org vs. individual repo fork).
* [X] merged in latest `origin/main`
* [X] added
solrbot opened a new pull request, #3143:
URL: https://github.com/apache/solr/pull/3143
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [com.google.code.gson:gson](https://redirect.github.com/google/gson) |
dependencies | minor |
HoustonPutman commented on PR #3142:
URL: https://github.com/apache/solr/pull/3142#issuecomment-2622059853
@dsmiley do you have any opinion on adding the snapshot directories to the
filter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922130#comment-17922130
]
Houston Putman commented on SOLR-17379:
---
I will add, the French date test only fail
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2622011097
> **Separately** in another issue/pr, NamedList needs some more attention
around this and toMap. Definitely deprecating that one.
I interpreted you thumbs up on my comment early as OK
dsmiley commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2621748542
> Wouldn't it be a better approach just to override asShallowMap in
SimpleOrderedMap and return itself?
:face-palm: of course; wow I have no excuse for myself. Not enough coffee
mayb
[
https://issues.apache.org/jira/browse/SOLR-17438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922089#comment-17922089
]
Jan Høydahl commented on SOLR-17438:
[~dsmiley] I know ASF have disabled personal hom
vesk0win closed issue #750: Use custom name for the ServiceAccount of Zookeeper
operator
URL: https://github.com/apache/solr-operator/issues/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
vesk0win commented on issue #750:
URL: https://github.com/apache/solr-operator/issues/750#issuecomment-2621005805
thanks, i tried it out and it works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
renatoh commented on PR #3048:
URL: https://github.com/apache/solr/pull/3048#issuecomment-2620972046
> As part of this PR, let's have NamedList.asShallowMap do an instanceof
check for Map and return it if so. That will lead to real usage / code coverage
of the changes you've done.
Wo
[
https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922006#comment-17922006
]
Bruno Roustant commented on SOLR-17504:
---
Thanks Houston
> CoreContainer calls Upda
49 matches
Mail list logo
