dsmiley commented on code in PR #3140: URL: https://github.com/apache/solr/pull/3140#discussion_r1934925281
########## solr/modules/cross-dc/src/java/org/apache/solr/crossdc/common/MirroredSolrRequest.java: ########## @@ -247,10 +246,10 @@ public boolean equals(final Object o) { } public static void setParams(SolrRequest<?> request, ModifiableSolrParams params) { - if (request instanceof MirroredAdminRequest) { - ((MirroredAdminRequest) request).setParams(params); - } else if (request instanceof UpdateRequest) { - ((UpdateRequest) request).setParams(params); + if (request instanceof MirroredAdminRequest mReq) { Review Comment: yeah it's a very nice Java 16 thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org