dsmiley commented on code in PR #3140:
URL: https://github.com/apache/solr/pull/3140#discussion_r1934914237
##########
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##########
@@ -91,9 +91,6 @@ public static void squashIntoNamedListWithoutHeader(
}
public static String getMediaTypeFromWtParam(SolrParams params, String
defaultMediaType) {
- if (params == null) {
Review Comment:
Okay I'll remove. I suppose the scope of this PR should be more focused on
SolrJ QueryRequest not server side SolrQueryRequest. Granted, I'd wish for the
same for SolrQueryRequest.getParams; same rationale for doing it in SolrJ. I
_could_ increase the scope to that but maybe too much in one PR; not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
