[
https://issues.apache.org/jira/browse/SOLR-17535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895852#comment-17895852
]
David Smiley commented on SOLR-17535:
-
Also planning on removing ClusterState.forEach
dsmiley commented on code in PR #2846:
URL: https://github.com/apache/solr/pull/2846#discussion_r1830327967
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1115,20 +1110,20 @@ protected String getRemoteCoreUrl(String
collectionName, String origCorename)
dsmiley commented on code in PR #2846:
URL: https://github.com/apache/solr/pull/2846#discussion_r1830305417
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -411,28 +417,19 @@ public Set getHostAllowList() {
}
/**
- * Iterate over collection
dsmiley commented on code in PR #2846:
URL: https://github.com/apache/solr/pull/2846#discussion_r1830304901
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -172,7 +173,9 @@ public Collection getCollectionNames() {
* semantics of how collection li
dsmiley commented on code in PR #2846:
URL: https://github.com/apache/solr/pull/2846#discussion_r1830303399
##
solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java:
##
@@ -1067,6 +1068,10 @@ public void testDeleteAliasedCollection() throws
Exception {
dsmiley commented on code in PR #2846:
URL: https://github.com/apache/solr/pull/2846#discussion_r1830301431
##
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java:
##
@@ -1094,20 +1094,19 @@ private SolrCore checkProps(ZkNodeProps zkProps) {
private void getSlicesF
github-actions[bot] commented on PR #1994:
URL: https://github.com/apache/solr/pull/1994#issuecomment-2458436058
This PR has had no activity for 60 days and is now labeled as stale. Any
new activity will remove the stale label. To attract more reviewers, please
tag people who might be fam
murblanc commented on code in PR #2846:
URL: https://github.com/apache/solr/pull/2846#discussion_r1830057908
##
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteCollectionCmd.java:
##
@@ -175,14 +175,12 @@ public void call(ClusterState state, ZkNodeProps message,
malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1830112416
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -569,7 +564,7 @@ private void updateIncludeFileEnableAuth(
includeFileLines.add("REM The follow
[
https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895822#comment-17895822
]
ASF subversion and git services commented on SOLR-17321:
Commit 6
malliaridis merged PR #2804:
URL: https://github.com/apache/solr/pull/2804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
epugh commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1830091572
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -569,7 +564,7 @@ private void updateIncludeFileEnableAuth(
includeFileLines.add("REM The following li
epugh commented on code in PR #2835:
URL: https://github.com/apache/solr/pull/2835#discussion_r1830090073
##
dev-tools/scripts/refguide/htaccess.txt:
##
@@ -1,6 +1,6 @@
# Existing pages moved to sub path in the 9.0 guide
RedirectMatch 301
^/guide/(about-this-guide|relevance|s
malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1830087669
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -569,7 +564,7 @@ private void updateIncludeFileEnableAuth(
includeFileLines.add("REM The follow
epugh commented on code in PR #2835:
URL: https://github.com/apache/solr/pull/2835#discussion_r1830076740
##
solr/webapp/web/partials/login.html:
##
@@ -60,23 +60,6 @@ Basic Authentication
-
-Kerberos Authentication
-Your browser did not provide the required in
epugh commented on PR #2835:
URL: https://github.com/apache/solr/pull/2835#issuecomment-2458257873
> There are some more hadoop auth cleanup in the security.policy
>
> *
https://github.com/apache/solr/blob/main/solr/server/etc/security.policy#L134
>
> *
https://github.
epugh commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2458253764
Okay, I think this may be finally ready to merge to `main` (only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
HoustonPutman closed pull request #2847: Ability to use a java version >21
URL: https://github.com/apache/solr/pull/2847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
HoustonPutman commented on PR #2847:
URL: https://github.com/apache/solr/pull/2847#issuecomment-2458247545
I'll close in favor of your PR @malliaridis !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
HoustonPutman commented on PR #2804:
URL: https://github.com/apache/solr/pull/2804#issuecomment-2458246549
Just pushed to yours! It would be cool to get it to java 21 for the
non-solrj/api modules. But this is a good first step!
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SOLR-17545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-17545.
---
Fix Version/s: 9.8
Assignee: Houston Putman
Resolution: Done
> Upgrade Gradle
[
https://issues.apache.org/jira/browse/SOLR-17545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895809#comment-17895809
]
ASF subversion and git services commented on SOLR-17545:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-17545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895808#comment-17895808
]
ASF subversion and git services commented on SOLR-17545:
Commit a
malliaridis commented on PR #2847:
URL: https://github.com/apache/solr/pull/2847#issuecomment-2458163235
There has been a separate PR for ECJ update with no reviewers yet. See
https://github.com/apache/solr/pull/2804. If ECJ is addressed here, please
close the other PR as well. :)
--
Thi
[
https://issues.apache.org/jira/browse/SOLR-17545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895795#comment-17895795
]
ASF subversion and git services commented on SOLR-17545:
Commit a
HoustonPutman merged PR #2848:
URL: https://github.com/apache/solr/pull/2848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apa
HoustonPutman commented on PR #2848:
URL: https://github.com/apache/solr/pull/2848#issuecomment-2458006311
I used the update wrapper script like you did for 8.4 @risdenk (while
keeping the custom stuff in), mind checking it again real quick?
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/SOLR-17545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17545:
--
Labels: pull-request-available (was: )
> Upgrade Gradle version to 8.10
>
Houston Putman created SOLR-17545:
-
Summary: Upgrade Gradle version to 8.10
Key: SOLR-17545
URL: https://issues.apache.org/jira/browse/SOLR-17545
Project: Solr
Issue Type: Improvement
S
HoustonPutman opened a new pull request, #2847:
URL: https://github.com/apache/solr/pull/2847
Related to: https://github.com/apache/solr/pull/2682
I was trying to use Gradle with a version > 21, and was having issues. I
think these fell through the cracks in the first PR, so let's upd
dsmiley opened a new pull request, #2846:
URL: https://github.com/apache/solr/pull/2846
https://issues.apache.org/jira/browse/SOLR-17535
This PR builds on top of the previous PR #2834 , you can ignore changes here
for that (the first set of commits on this PR) as that's reviewed separ
mkhludnev commented on PR #2742:
URL: https://github.com/apache/solr/pull/2742#issuecomment-2457540717
I'm not sure it may work, since ValueSourceParser is invoked by FuncQParser
with fixed interface.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-17538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895651#comment-17895651
]
ASF subversion and git services commented on SOLR-17538:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-17538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895637#comment-17895637
]
ASF subversion and git services commented on SOLR-17538:
Commit 7
iamsanjay merged PR #2832:
URL: https://github.com/apache/solr/pull/2832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
dsmiley commented on PR #2832:
URL: https://github.com/apache/solr/pull/2832#issuecomment-2457334718
CHANGES.txt: I would lean to not do so but it's borderline to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
risdenk commented on PR #2835:
URL: https://github.com/apache/solr/pull/2835#issuecomment-2457312337
There are some more hadoop auth cleanup in the security.policy
*
https://github.com/apache/solr/blob/main/solr/server/etc/security.policy#L134
*
https://github.com/apache/solr/blob
janhoy commented on code in PR #2835:
URL: https://github.com/apache/solr/pull/2835#discussion_r1829415643
##
solr/webapp/web/partials/login.html:
##
@@ -60,23 +60,6 @@ Basic Authentication
-
-Kerberos Authentication
-Your browser did not provide the required i
psalagnac commented on code in PR #2737:
URL: https://github.com/apache/solr/pull/2737#discussion_r1829398709
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
##
@@ -242,45 +240,15 @@ public static void waitForCollectionToDisappear(
log.
[
https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895615#comment-17895615
]
Jan Høydahl commented on SOLR-4587:
---
Thanks for the huge contribution in the PR. I see i
[
https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-4587:
--
Fix Version/s: (was: 6.0)
> Implement Saved Searches a la ElasticSearch Percolator
> ---
[
https://issues.apache.org/jira/browse/SOLR-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-4587:
-
Labels: pull-request-available (was: )
> Implement Saved Searches a la ElasticSearch Percolator
>
zzBrunoBrito commented on PR #2382:
URL: https://github.com/apache/solr/pull/2382#issuecomment-2457194083
I'm really excited about this PR because that looks like a great feature to
use. Are there any updates on this?
--
This is an automated message from the Apache Git Service.
To respond
iamsanjay commented on PR #2832:
URL: https://github.com/apache/solr/pull/2832#issuecomment-2457186134
@dsmiley Should there be change.txt for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
iamsanjay commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1829342093
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -421,6 +421,10 @@ private void registerWatcher() throws KeeperException {
return;
iamsanjay commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1829342093
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -421,6 +421,10 @@ private void registerWatcher() throws KeeperException {
return;
gerlowskija merged PR #2811:
URL: https://github.com/apache/solr/pull/2811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1829214292
##
solr/core/src/java/org/apache/solr/cli/Tool.java:
##
@@ -50,7 +50,19 @@ default String getFooter() {
return "\nPlease see the Reference Guide for more tools do
malliaridis merged PR #2845:
URL: https://github.com/apache/solr/pull/2845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
timatbw commented on PR #2742:
URL: https://github.com/apache/solr/pull/2742#issuecomment-2456921063
Good points, yes I did notice that the parent parser would not be available
via the simple localParams approach, but I didn't realise that SolrParams only
support String values not arbitrary
epugh commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1829171164
##
solr/core/src/java/org/apache/solr/cli/Tool.java:
##
@@ -50,7 +50,19 @@ default String getFooter() {
return "\nPlease see the Reference Guide for more tools document
Eric Pugh created SOLR-17544:
Summary: Prevent conflicting connection options(-s and -z) from
being used
Key: SOLR-17544
URL: https://issues.apache.org/jira/browse/SOLR-17544
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-17544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17544:
--
Labels: pull-request-available (was: )
> Prevent conflicting connection options(-s and -z) fro
epugh commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1829172295
##
solr/core/src/java/org/apache/solr/cli/ToolBase.java:
##
@@ -48,9 +52,30 @@ protected void echo(final String msg) {
stdout.println(msg);
}
+ @Override
+ publi
mkhludnev commented on PR #2742:
URL: https://github.com/apache/solr/pull/2742#issuecomment-2456782850
> you can already achieve the desired results using the existing mechanism
`type:func`
I'm made a simple experiment. ~~this time, you won't drop my commit~~ Mind
the file location,
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1829033956
##
solr/webapp/web/currentUi/libs/jquery-ui.min.js:
##
@@ -1,28 +1,20 @@
-/*!
-
-Copyright 2014 jQuery Foundation and other contributors
-http://jquery.com/
-
-Permiss
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828821379
##
solr/webapp/web/currentUi/css/angular/chosen.css:
##
@@ -1,36 +1,20 @@
/*
-Chosen
-- by Patrick Filler for Harvest http://getharvest.com
-- Copyright (c) 2011-2018
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828829198
##
solr/webapp/web/currentUi/css/angular/ui-grid.min.css:
##
@@ -1,4 +1,17 @@
-/*!
- * ui-grid - v4.10.0 - 2021-02-01
- * Copyright (c) 2021 ; License: MIT
+/*
+ * Li
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828837251
##
solr/webapp/web/currentUi/libs/angular-resource.js:
##
@@ -0,0 +1,929 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828839351
##
solr/webapp/web/currentUi/libs/angular-sanitize.min.js:
##
@@ -1,22 +1,20 @@
/*
-The MIT License
-Copyright (c) 2010-2015 Google, Inc. http://angularjs.org
-Permis
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828840814
##
solr/webapp/web/currentUi/libs/chosen.jquery.min.js:
##
@@ -1,24 +1,20 @@
/*
-Chosen
-- by Patrick Filler for Harvest http://getharvest.com
-- Copyright (c) 2011-2
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828841578
##
solr/webapp/web/currentUi/libs/ngtimeago.js:
##
@@ -1,25 +1,20 @@
/*
-Copyright (c) 2014 Uttesh Kumar
-
-Permission is hereby granted, free of charge, to any perso
malliaridis commented on code in PR #2818:
URL: https://github.com/apache/solr/pull/2818#discussion_r1828829198
##
solr/webapp/web/currentUi/css/angular/ui-grid.min.css:
##
@@ -1,4 +1,17 @@
-/*!
- * ui-grid - v4.10.0 - 2021-02-01
- * Copyright (c) 2021 ; License: MIT
+/*
+ * Li
63 matches
Mail list logo
