iamsanjay commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1829342093
##########
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##########
@@ -421,6 +421,10 @@ private void registerWatcher() throws KeeperException {
return;
}
retryRegisterWatcher();
+ // if term node is deleted, refresh cannot possibly succeed
+ if (Watcher.Event.EventType.NodeDeleted == event.getType()) {
+ return;
+ }
Review Comment:
I believe there is a race condition present here.
https://ge.apache.org/s/v3axcavyii5bo/tests/task/:solr:core:test/details/org.apache.solr.cloud.TestPullReplica/testCreateDelete%20%7Bseed%3D%5B89704FD072930E71:9260BE9C8463F641%5D%7D?top-execution=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
