janhoy commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1829415643
########## solr/webapp/web/partials/login.html: ########## @@ -60,23 +60,6 @@ <h1>Basic Authentication</h1> </div> - <div ng-show="authScheme === 'Negotiate'"> - <h1>Kerberos Authentication</h1> - <p>Your browser did not provide the required information to authenticate using Kerberos. - Please check that your computer has a valid ticket for communicating with Solr, - and that your browser is properly configured to provide that ticket when required. - For more information, consult - <a href="https://solr.apache.org/guide/solr/latest/deployment-guide/kerberos-authentication-plugin.html";> - Solr's Kerberos documentation - </a>. - </p> - The response from the server was: - <hr/> - <pre>HTTP 401 {{statusText}} -WWW-Authenticate: {{wwwAuthHeader}}</pre> - <hr/> - </div> Review Comment: There is also traces of `Negotiate` authScheme in `login.js` ########## dev-tools/scripts/refguide/htaccess.txt: ########## @@ -1,6 +1,6 @@ # Existing pages moved to sub path in the 9.0 guide RedirectMatch 301 ^/guide/(about-this-guide|relevance|solr-glossary|solr-tutorial)\.html /guide/solr/latest/getting-started/$1.html -RedirectMatch 301 ^/guide/(aliases|audit-logging|authentication-and-authorization-plugins|basic-authentication-plugin|circuit-breakers|client-apis|cloud-screens|cluster-node-management|collection-management|collections-core-admin|configuring-logging|enabling-ssl|hadoop-authentication-plugin|indexupgrader-tool|installing-solr|jvm-settings|jwt-authentication-plugin|kerberos-authentication-plugin|mbean-request-handler|metrics-reporting|performance-statistics-reference|ping|plugins-stats-screen|replica-management|rule-based-authorization-plugin|securing-solr|security-ui|shard-management|solr-control-script-reference|solrcloud-recoveries-and-write-tolerance|solrcloud-with-legacy-configuration-files|taking-solr-to-production|thread-dump|upgrading-a-solr-cluster|zookeeper-access-control|cert-authentication-plugin)\.html /guide/solr/latest/deployment-guide/$1.html +RedirectMatch 301 ^/guide/(aliases|audit-logging|authentication-and-authorization-plugins|basic-authentication-plugin|circuit-breakers|client-apis|cloud-screens|cluster-node-management|collection-management|collections-core-admin|configuring-logging|enabling-ssl|indexupgrader-tool|installing-solr|jvm-settings|jwt-authentication-plugin|mbean-request-handler|metrics-reporting|performance-statistics-reference|ping|plugins-stats-screen|replica-management|rule-based-authorization-plugin|securing-solr|security-ui|shard-management|solr-control-script-reference|solrcloud-recoveries-and-write-tolerance|solrcloud-with-legacy-configuration-files|taking-solr-to-production|thread-dump|upgrading-a-solr-cluster|zookeeper-access-control|cert-authentication-plugin)\.html /guide/solr/latest/deployment-guide/$1.html Review Comment: Instead of this, you should edit `mappings.csv` and `gen-refguide-redirects.py` similar to how the `_8_11` links for removed features in 9.x will then generate a `htaccess.txt` that redirect those pages to latest 8.x. So everything removed in 9.x should have the "latest" link redirect to a concrete 9.x version... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
