epugh commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1829171164
##########
solr/core/src/java/org/apache/solr/cli/Tool.java:
##########
@@ -50,7 +50,19 @@ default String getFooter() {
return "\nPlease see the Reference Guide for more tools documentation:
https://solr.apache.org/guide/solr/latest/deployment-guide/solr-control-script-reference.html";;
}
- List<Option> getOptions();
+ /**
Review Comment:
I find the getAllOptions and getOPtions very confusing, especially because
we have logic in ToolBase that even goes through and uses getAllOptions and
then iterates and checks that if they are deprecated and removes them. I also
think that the only use of the "getOptions" is in the help.. I'll try to
refactor this and we can see if we like the commit or not!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
