[jira] [Updated] (SOLR-13749) Implement support for joining across collections with multiple shards ( XCJF )

2024-09-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-13749: -- Labels: pull-request-available (was: ) > Implement support for joining across collections with

Re: [PR] Benchmark: HTTP2 fix cancel_stream_error [solr]

2024-09-18 Thread via GitHub
iamsanjay commented on PR #2612: URL: https://github.com/apache/solr/pull/2612#issuecomment-2359947816 Was there anyway to enable more logs for benchmark? I wonder If it's too much overhead with the current Jetty configuration. ``` org.apache.solr.client.solrj.impl.BaseHttpSolrClient$R

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-18 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1766118550 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedColl

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-18 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1766116768 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedColl

Re: [PR] SOLR-16503: New home for default http2 client [solr]

2024-09-18 Thread via GitHub
iamsanjay commented on code in PR #2689: URL: https://github.com/apache/solr/pull/2689#discussion_r1766116768 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -2563,6 +2581,11 @@ public PlacementPluginFactory getPlacementPlugi return this.distributedColl

[jira] [Commented] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882827#comment-17882827 ] Christos Malliaridis commented on SOLR-17457: - [~epugh] I've also created a b

Re: [PR] SOLR-15689: add PeerSyncTest.missedUpdatesFinderTests() [solr]

2024-09-18 Thread via GitHub
github-actions[bot] commented on PR #343: URL: https://github.com/apache/solr/pull/343#issuecomment-2359646644 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please tag

[PR] SOLR-17457: Backport fix for max-wait-secs [solr]

2024-09-18 Thread via GitHub
malliaridis opened a new pull request, #2719: URL: https://github.com/apache/solr/pull/2719 https://issues.apache.org/jira/browse/SOLR-17457 # Description This PR backports the changes from https://github.com/apache/solr/pull/2717 to `branch_9_7`. # Checklist Plea

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-18 Thread via GitHub
janhoy commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2359604116 Feel free to jump in and commit to this PR if you have ideas. I'll eventually come around to it and can do a pull... -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
janhoy commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765867710 ## solr/packaging/test/test_create.bats: ## @@ -34,8 +34,31 @@ teardown() { assert_output --partial "Created new core 'COLL_NAME'" } +@test "create_core works" { + r

[jira] [Resolved] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-17457. -- Fix Version/s: 9.8 Resolution: Fixed > StatusTool does not support --max-wait-secs > ---

Re: [PR] [SOLR-10059] Handle appended fq params with macros in distributed requests [solr]

2024-09-18 Thread via GitHub
dsmiley commented on code in PR #2303: URL: https://github.com/apache/solr/pull/2303#discussion_r1765590200 ## solr/core/src/test/org/apache/solr/handler/component/SearchHandlerAppendsWithMacrosCloudTest.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundati

[jira] [Updated] (SOLR-17458) Metrics: switch from DropWizard to OpenTelemetry

2024-09-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17458: Summary: Metrics: switch from DropWizard to OpenTelemetry (was: OpenTelemetry integration for metr

[jira] [Updated] (SOLR-17458) OpenTelemetry integration for metrics

2024-09-18 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17458: Priority: Major (was: Minor) > OpenTelemetry integration for metrics > ---

[jira] [Created] (SOLR-17458) OpenTelemetry integration for metrics

2024-09-18 Thread Matthew Biscocho (Jira)
Matthew Biscocho created SOLR-17458: --- Summary: OpenTelemetry integration for metrics Key: SOLR-17458 URL: https://issues.apache.org/jira/browse/SOLR-17458 Project: Solr Issue Type: Improvem

Re: [PR] SOLR-16976: Remove log4j-jul jar and use slf4j bridge for JUL [solr]

2024-09-18 Thread via GitHub
dsmiley commented on code in PR #2703: URL: https://github.com/apache/solr/pull/2703#discussion_r1765570728 ## solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java: ## @@ -133,6 +134,9 @@ public SolrDispatchFilter() {} @Override public void init(FilterConfig

[PR] SOLR-17457: Scavange one change from the SOLR-17457 bug fix for main [solr]

2024-09-18 Thread via GitHub
epugh opened a new pull request, #2718: URL: https://github.com/apache/solr/pull/2718 https://issues.apache.org/jira/browse/SOLR-17457 This is a big one! I committed to branch_9_7, and then branch_9x, and wanted to get this one improvement into main. -- This is an automated messa

Re: [PR] Enable PRS for all cloud tests [solr]

2024-09-18 Thread via GitHub
dsmiley commented on PR #2199: URL: https://github.com/apache/solr/pull/2199#issuecomment-2358965812 @noblepaul status on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [SOLR-10059] Handle appended fq params with macros in distributed requests [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2303: URL: https://github.com/apache/solr/pull/2303#issuecomment-2358964261 Nice discussion during community meeting today about this one, and thank you @dsmiley for being willing to look at this one as well. -- This is an automated message from the Apache Git Servi

[jira] [Commented] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882759#comment-17882759 ] ASF subversion and git services commented on SOLR-17457: Commit c

Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]

2024-09-18 Thread via GitHub
epugh merged PR #2717: URL: https://github.com/apache/solr/pull/2717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2717: URL: https://github.com/apache/solr/pull/2717#issuecomment-2358936662 I ran the test that failed locally, and it looks great -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2710: URL: https://github.com/apache/solr/pull/2710#issuecomment-2358918287 @janhoy I've gone through and addressed (hopefully!) all your commits. Can I get a LGTM? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2710: URL: https://github.com/apache/solr/pull/2710#issuecomment-2358916490 > Thanks for quick PR. Looking good, not taken it for a spin, but very nice with the BATS tests. > > Will we need edit to `solr.cmd` you think? Checked and yes, we had to fix heal

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765362678 ## solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java: ## @@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient cloudSolrClient, CommandLine cli) th

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765299626 ## solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java: ## @@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient cloudSolrClient, CommandLine cli) th

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765266710 ## solr/core/src/java/org/apache/solr/cli/ToolBase.java: ## @@ -34,18 +34,29 @@ protected ToolBase(PrintStream stdout) { } protected void echoIfVerbose(final String

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765264771 ## solr/packaging/test/test_create.bats: ## @@ -34,8 +34,31 @@ teardown() { assert_output --partial "Created new core 'COLL_NAME'" } +@test "create_core works" { + ru

Re: [PR] Fix bugs in bin/solr in branch_9_7 [solr]

2024-09-18 Thread via GitHub
epugh commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765232692 ## solr/packaging/test/test_healthcheck.bats: ## @@ -29,8 +29,9 @@ teardown() { } @test "healthcheck on cloud solr" { - solr start -c -e films - run solr healthcheck -

Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2717: URL: https://github.com/apache/solr/pull/2717#issuecomment-2358712334 Clicked wrong button! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]

2024-09-18 Thread via GitHub
epugh closed pull request #2717: SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd URL: https://github.com/apache/solr/pull/2717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2717: URL: https://github.com/apache/solr/pull/2717#issuecomment-2358711806 I just triggered the tests, and once they pass will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-09-18 Thread via GitHub
epugh commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2358707530 Okay, I see the challenge with StatusTool. StatusTool *should* support `--credentials`. Look at the tests, you can see we do: ``` "--credentials", SecurityJson.USER_PA

[jira] [Assigned] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-17457: Assignee: Eric Pugh > StatusTool does not support --max-wait-secs > --

[jira] [Updated] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17457: -- Labels: cli pull-request-available (was: cli) > StatusTool does not support --max-wait-secs >

[PR] SOLR-17457: Fix support for --max-wait-secs for bin/solr.cmd [solr]

2024-09-18 Thread via GitHub
malliaridis opened a new pull request, #2717: URL: https://github.com/apache/solr/pull/2717 https://issues.apache.org/jira/browse/SOLR-17457 # Description On Windows the `bin/solr.cmd` uses the StatusTool with `--max-wait-secs`, but the flag is not supported in the new notation

[jira] [Updated] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17457: Description: With the changes made in SOLR-16824 the StatusTool is used by bin/solr

[jira] [Created] (SOLR-17457) StatusTool does not support --max-wait-secs

2024-09-18 Thread Christos Malliaridis (Jira)
Christos Malliaridis created SOLR-17457: --- Summary: StatusTool does not support --max-wait-secs Key: SOLR-17457 URL: https://issues.apache.org/jira/browse/SOLR-17457 Project: Solr Issue

[jira] [Commented] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-09-18 Thread Pierre Salagnac (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882649#comment-17882649 ] Pierre Salagnac commented on SOLR-17453: {quote}FYI note the issue links to a dev

[jira] [Updated] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-09-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17453: -- Labels: newdev pull-request-available (was: newdev) > Replace CloudUtil.waitForState and some

[PR] SOLR-17453: Drop CloudUtil.waitForState() in favor of common waitForState() [solr]

2024-09-18 Thread via GitHub
psalagnac opened a new pull request, #2716: URL: https://github.com/apache/solr/pull/2716 https://issues.apache.org/jira/browse/SOLR-17453 _(this does not fully address the ticket)_ # Description Method `CloudUtil.waitForState()` does use a Zookeeper watch, bu

[jira] [Commented] (SOLR-17454) ERROR message in logs with multithreaded searches

2024-09-18 Thread Andrew Hankinson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882646#comment-17882646 ] Andrew Hankinson commented on SOLR-17454: - [~cpoerschke] thank you for confirming

[PR] add RawTFSimilarityFactory class [solr]

2024-09-18 Thread via GitHub
cpoerschke opened a new pull request, #2715: URL: https://github.com/apache/solr/pull/2715 https://github.com/apache/lucene/pull/13749 for `RawTFSimilarity` (hopefully in (the not yet released) Lucene 9.12 version -- keeping this PR as draft until Solr is upgraded to use Lucene 9.12) --