dsmiley commented on code in PR #2703:
URL: https://github.com/apache/solr/pull/2703#discussion_r1765570728
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -133,6 +134,9 @@ public SolrDispatchFilter() {}
@Override
public void init(FilterConfig config) throws ServletException {
try {
+ SLF4JBridgeHandler.removeHandlersForRootLogger();
+ SLF4JBridgeHandler.install();
Review Comment:
This logic should ideally be done as early as possible. A ServletFilter's
init method is not actually so early as we can do. We could do
CoreContainerProvider.init() which will start up CoreContainer _before_ the
ServletFilter. But we could _do earlier than that_ by **adding some XML based
configuration in jetty.xml, which I think makes more sense**. It could also
mean we add the dependency JAR without formerly making it a dependency of
solr-core, thus wouldn't leak to other/external things projects that might want
to depend on solr-core. This is a deployment matter so it's best done at the
Jetty layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
