janhoy commented on code in PR #2710: URL: https://github.com/apache/solr/pull/2710#discussion_r1765867710
########## solr/packaging/test/test_create.bats: ########## @@ -34,8 +34,31 @@ teardown() { assert_output --partial "Created new core 'COLL_NAME'" } +@test "create_core works" { + run solr start + run solr create_core -c COLL_NAME + assert_output --partial "Created new core 'COLL_NAME'" +} + @test "create for cloud mode" { run solr start -c run solr create -c COLL_NAME assert_output --partial "Created collection 'COLL_NAME'" } + +@test "ensure -p port parameter is supported" { + solr start -p ${SOLR2_PORT} + solr assert --not-started http://localhost:${SOLR_PORT} --timeout 5000 + solr assert --started http://localhost:${SOLR2_PORT} --timeout 5000 + + run solr create -c COLL_NAME -p ${SOLR2_PORT} + assert_output --partial "Created new core 'COLL_NAME'" +} + +@test "ensure -V verbose parameter is supported" { + solr start + solr assert --started http://localhost:${SOLR_PORT} --timeout 5000 + + run solr create -c COLL_NAME -V + assert_output --partial "Created new core 'COLL_NAME'" Review Comment: Sure, I just expected the assert to fail without the `-V`, which it won't now since the text asserted is always printed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org