[
https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882649#comment-17882649
]
Pierre Salagnac commented on SOLR-17453:
----------------------------------------
{quote}FYI note the issue links to a dev list thread where there's more context
and even a suggested replacement for one spot I noticed.
{quote}
Thanks for the heads-up. I filled a pull-request that does not address this
yet, to keep changes small enough.
There are many places (CreateCollectionCmd and others) when we can also make
things simpler by using waitForState(). I will handle this as a second step.
> Replace CloudUtil.waitForState and some TimeOut with
> ZkStateReader.waitForState
> -------------------------------------------------------------------------------
>
> Key: SOLR-17453
> URL: https://issues.apache.org/jira/browse/SOLR-17453
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should universally use ZkStateReader.waitForState when waiting for the
> ClusterState to change based on a predicate. SolrCloudTestCase.waitForState
> is fine since it calls the former. But CloudUtil.waitForState does not; it
> should be replaced. Additionally, TimeOut is used in some places wait
> waitForState ought to be used, like CreateCollectionCmd.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
