[jira] [Commented] (SOLR-16924) Restore: Have RESTORECORE set the UpdateLog state

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772438#comment-17772438 ] ASF subversion and git services commented on SOLR-16924: Commit 8

Re: [PR] SOLR-16924: Refactor requestApplyUpdate step in action=RESTORE [solr]

2023-10-05 Thread via GitHub
dsmiley merged PR #1965: URL: https://github.com/apache/solr/pull/1965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Added equals/hashcode method to StateWatcher to avoid registering more than one StateWatecher [solr]

2023-10-05 Thread via GitHub
hiteshk25 closed pull request #1985: Added equals/hashcode method to StateWatcher to avoid registering more than one StateWatecher URL: https://github.com/apache/solr/pull/1985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] SOLR-16924: Refactor requestApplyUpdate step in action=RESTORE [solr]

2023-10-05 Thread via GitHub
dsmiley commented on PR #1965: URL: https://github.com/apache/solr/pull/1965#issuecomment-1749884015 Going to merge soon. 9x port will exclude the RestoreCmd part so we retain backwards-compatibility for in-place upgrades within the 9x line. BTW I'm so glad to see Crave working so we

Re: [PR] SOLR-16924: Refactor requestApplyUpdate step in action=RESTORE [solr]

2023-10-05 Thread via GitHub
dsmiley commented on PR #1965: URL: https://github.com/apache/solr/pull/1965#issuecomment-1749874194 I'll be pushing this to main with a CHANGES.txt and upgrade note for getting to 10. In 9x I will omit the RestoreCmd part but will add a comment about it disappearing in 10. -- This is a

[PR] Added equals/hashcode method to StateWatcher to avoid registering more than one StateWatecher [solr]

2023-10-05 Thread via GitHub
hiteshk25 opened a new pull request, #1985: URL: https://github.com/apache/solr/pull/1985 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] SOLR-15831: Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI [solr]

2023-10-05 Thread via GitHub
epugh commented on PR #504: URL: https://github.com/apache/solr/pull/504#issuecomment-1749853307 Hey @thelabdude I went through this PR, and I think at this point I've combed out all the good stuff in this PR already and have committed them in various PR's.Are you comfortable with me cl

[PR] Fix appProtocol issue for non-TLS SolrClouds [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman opened a new pull request, #641: URL: https://github.com/apache/solr-operator/pull/641 Fixes #640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[jira] (SOLR-15831) Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI

2023-10-05 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15831 ] Eric Pugh deleted comment on SOLR-15831: -- was (Author: epugh): See this PR: https://github.com/apache/solr/pull/504 > Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help t

[jira] [Commented] (SOLR-15831) Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI

2023-10-05 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772392#comment-17772392 ] Eric Pugh commented on SOLR-15831: -- See this PR: https://github.com/apache/solr/pull/504

Re: [PR] SOLR-15831: Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI [solr]

2023-10-05 Thread via GitHub
epugh commented on PR #504: URL: https://github.com/apache/solr/pull/504#issuecomment-1749683189 Boy I wish I had seen this PR a long time ago...A lot of good stuff in here... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format

2023-10-05 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772327#comment-17772327 ] Matthew Biscocho commented on SOLR-10654: - Thanks [~dsmiley] for helping bring th

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format

2023-10-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772321#comment-17772321 ] David Smiley commented on SOLR-10654: - I propose to edit this work item with the titl

[jira] [Commented] (SOLR-11795) Add Solr metrics exporter for Prometheus

2023-10-05 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772312#comment-17772312 ] Matthew Biscocho commented on SOLR-11795: - Just to revive discussion on this sinc

Re: [PR] Bump github.com/cyphar/filepath-securejoin from 0.2.3 to 0.2.4 [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman merged PR #617: URL: https://github.com/apache/solr-operator/pull/617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

Re: [PR] SOLR-17012: Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0 [solr]

2023-10-05 Thread via GitHub
risdenk commented on PR #1743: URL: https://github.com/apache/solr/pull/1743#issuecomment-1749267433 FWIW I put together https://issues.apache.org/jira/browse/HADOOP-18922 and https://github.com/apache/hadoop/pull/6150 to address the race condition upstream. -- This is an automated messa

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken due to tracing

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Resolution: Fixed Status: Resolved (was: Patch Available) > Solr Benchmarks are broken due

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken due to tracing

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Summary: Solr Benchmarks are broken due to tracing (was: Solr Benchmarks are broken) > Solr Bench

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Fix Version/s: 9.4 > Solr Benchmarks are broken > -- > > Ke

[jira] [Commented] (SOLR-16960) Tests should sometimes run with a Tracer (not no-op)

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772288#comment-17772288 ] ASF subversion and git services commented on SOLR-16960: Commit e

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772287#comment-17772287 ] ASF subversion and git services commented on SOLR-17014: Commit e

[jira] [Commented] (SOLR-16960) Tests should sometimes run with a Tracer (not no-op)

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772285#comment-17772285 ] ASF subversion and git services commented on SOLR-16960: Commit 7

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772284#comment-17772284 ] ASF subversion and git services commented on SOLR-17014: Commit 7

Re: [PR] Bump google.golang.org/grpc from 1.49.0 to 1.53.0 [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman closed pull request #584: Bump google.golang.org/grpc from 1.49.0 to 1.53.0 URL: https://github.com/apache/solr-operator/pull/584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Bump google.golang.org/grpc from 1.49.0 to 1.53.0 [solr-operator]

2023-10-05 Thread via GitHub
dependabot[bot] commented on PR #584: URL: https://github.com/apache/solr-operator/pull/584#issuecomment-1749257257 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] Bump google.golang.org/grpc from 1.49.0 to 1.53.0 [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman commented on PR #584: URL: https://github.com/apache/solr-operator/pull/584#issuecomment-1749257186 This is done by #633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Upgrade dependencies [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman merged PR #633: URL: https://github.com/apache/solr-operator/pull/633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

Re: [PR] Upgrade dependencies [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman commented on PR #633: URL: https://github.com/apache/solr-operator/pull/633#issuecomment-1749254518 Ok this should be good to go, I tested the custom namespace watching manually and it worked! Hopefully we can get that integration tested eventually, but it'd add a lot of time

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Fix Version/s: main (10.0) > Solr Benchmarks are broken > -- > >

Re: [PR] SOLR-17014: Ensure that injecting random recording flag only happens under randomized context SOLR-16960 [solr]

2023-10-05 Thread via GitHub
risdenk merged PR #1983: URL: https://github.com/apache/solr/pull/1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772280#comment-17772280 ] ASF subversion and git services commented on SOLR-17014: Commit 9

[jira] [Commented] (SOLR-16960) Tests should sometimes run with a Tracer (not no-op)

2023-10-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772281#comment-17772281 ] ASF subversion and git services commented on SOLR-16960: Commit 9

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 6 [solr]

2023-10-05 Thread via GitHub
epugh commented on PR #1978: URL: https://github.com/apache/solr/pull/1978#issuecomment-1749247433 These API's are all experimental and new, so introducing `/collection/standalone/` into the "sorta classic" core urls is actually allowed ;-). And think about it helping folks in the future

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 6 [solr]

2023-10-05 Thread via GitHub
epugh commented on PR #1978: URL: https://github.com/apache/solr/pull/1978#issuecomment-1749244086 I think in the balance, I'm leaning to towards "store", because resources could mean many thing... "dataStoreType" and "dataStoreName" ? Or, we could just rip the bandaid off and ge

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772274#comment-17772274 ] Alex Deparvu commented on SOLR-17014: - ah good find.[~krisden]. had no idea this can

[jira] [Updated] (SOLR-17013) SaslZkACLProviderTestMethod.testSaslZkACLProvider fails consistently on MAcOSX -- evidently due to SocketPermission

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17013: Status: Patch Available (was: Open) > SaslZkACLProviderTestMethod.testSaslZkACLProvider fails cons

[jira] [Assigned] (SOLR-17013) SaslZkACLProviderTestMethod.testSaslZkACLProvider fails consistently on MAcOSX -- evidently due to SocketPermission

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-17013: --- Assignee: Kevin Risden > SaslZkACLProviderTestMethod.testSaslZkACLProvider fails consistentl

[jira] [Commented] (SOLR-17013) SaslZkACLProviderTestMethod.testSaslZkACLProvider fails consistently on MAcOSX -- evidently due to SocketPermission

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772273#comment-17772273 ] Kevin Risden commented on SOLR-17013: - So I put up a PR that forces the use of 127.0.

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1749203775 Failing tests are passing locally, they ma be flappers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] No Jira: some release script tweaks [solr]

2023-10-05 Thread via GitHub
madrob commented on code in PR #1976: URL: https://github.com/apache/solr/pull/1976#discussion_r1347652432 ## dev-tools/scripts/releaseWizard.yaml: ## @@ -636,7 +636,7 @@ groups: Ask on dev@ for input. Ideally the timing of this request mostly coincides with the r

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 6 [solr]

2023-10-05 Thread via GitHub
HoustonPutman commented on PR #1978: URL: https://github.com/apache/solr/pull/1978#issuecomment-1749182940 I'm also cool with resourceType and resourceName, but store is cool too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Bump minimum supported Solr version [solr-operator]

2023-10-05 Thread via GitHub
HoustonPutman commented on issue #616: URL: https://github.com/apache/solr-operator/issues/616#issuecomment-1749180457 Thanks for all of the awesome work here Jason! Yeah one more and we should be good to go! (And the ZK Bootstrapping will be great to get rid of!!) I think after that

Re: [PR] SOLR-16825: Migrate v2 definitions to 'api' module, pt 6 [solr]

2023-10-05 Thread via GitHub
gerlowskija commented on PR #1978: URL: https://github.com/apache/solr/pull/1978#issuecomment-1749083088 Haha, someone's enjoying their LLM's this morning 😛 "Store" is a tad generic for my tastes, but I like it better than "index" I think? We would have "store type" (which could eit

Re: [I] Bump minimum supported Solr version [solr-operator]

2023-10-05 Thread via GitHub
gerlowskija commented on issue #616: URL: https://github.com/apache/solr-operator/issues/616#issuecomment-1749074908 We've made pretty good progress on this via the linked issues. There's one last change we can do (involving our ZK-bootstrapping) to make sure we're taking advantage of all

Re: [I] Use /admin/info/health as default probe path [solr-operator]

2023-10-05 Thread via GitHub
gerlowskija closed issue #628: Use /admin/info/health as default probe path URL: https://github.com/apache/solr-operator/issues/628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Probes for readiness and liveness should be different [solr-operator]

2023-10-05 Thread via GitHub
gerlowskija closed issue #504: Probes for readiness and liveness should be different URL: https://github.com/apache/solr-operator/issues/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Use Solr's /admin/info/health for pod readiness checks [solr-operator]

2023-10-05 Thread via GitHub
gerlowskija merged PR #629: URL: https://github.com/apache/solr-operator/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

Re: [I] Bring solr.xml into line with current Solr default settings. [solr-operator]

2023-10-05 Thread via GitHub
gerlowskija closed issue #635: Bring solr.xml into line with current Solr default settings. URL: https://github.com/apache/solr-operator/issues/635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add sysprop driven XML tags to default solr.xml [solr-operator]

2023-10-05 Thread via GitHub
gerlowskija merged PR #636: URL: https://github.com/apache/solr-operator/pull/636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Status: Patch Available (was: Open) > Solr Benchmarks are broken > -- > >

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772226#comment-17772226 ] Kevin Risden commented on SOLR-17014: - https://github.com/apache/solr/pull/1983 pull

[PR] SOLR-17014: Ensure that injecting random recording flag only happens under randomized context SOLR-16960 [solr]

2023-10-05 Thread via GitHub
risdenk opened a new pull request, #1983: URL: https://github.com/apache/solr/pull/1983 https://issues.apache.org/jira/browse/SOLR-17014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Assigned] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-17014: --- Assignee: Kevin Risden > Solr Benchmarks are broken > -- > >

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Component/s: benchmarks > Solr Benchmarks are broken > -- > >

[jira] [Updated] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17014: Affects Version/s: 9.4 > Solr Benchmarks are broken > -- > >

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1777#comment-1777 ] Kevin Risden commented on SOLR-17014: - Short term workaround is ot add withTraceIdGen

[jira] [Commented] (SOLR-17014) Solr Benchmarks are broken

2023-10-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772221#comment-17772221 ] Kevin Risden commented on SOLR-17014: - It looks like this was inadvertently caused by

Re: [PR] SOLR-17012: Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0 [solr]

2023-10-05 Thread via GitHub
epugh commented on PR #1743: URL: https://github.com/apache/solr/pull/1743#issuecomment-1748846033 Is it worth having a ZK matrix in ref guide similar to the sections on Java in https://solr.apache.org/guide/solr/latest/deployment-guide/system-requirements.html#released-solr-and-java-versio

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1748843985 @dsmiley It's actually the same JIRA as #1928. It just split my end goal (making it easier to work with replica types and possibly add new ones) into several PRs. -- This is an automated me

Re: [PR] SOLR-17012: Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0 [solr]

2023-10-05 Thread via GitHub
risdenk commented on PR #1743: URL: https://github.com/apache/solr/pull/1743#issuecomment-1748819671 > > re: upgrade notes > > The existing notes don't address my point at all. And as we embrace Curator (in a separate issue), the lack of ZK 3.4 compatibility will become more pronounc

Re: [PR] SOLR-17012: Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0 [solr]

2023-10-05 Thread via GitHub
dsmiley commented on PR #1743: URL: https://github.com/apache/solr/pull/1743#issuecomment-1748805760 > re: upgrade notes The existing notes don't address my point at all. And as we embrace Curator (in a separate issue), the lack of ZK 3.4 compatibility will become more pronounced (n

[PR] SOLR-16542: Remove OverseerConfigSetMessageHandler [solr]

2023-10-05 Thread via GitHub
pvcnt opened a new pull request, #1982: URL: https://github.com/apache/solr/pull/1982 https://issues.apache.org/jira/browse/SOLR-16542 # Description `distributedCollectionConfigSetExecution` is a boolean setting on solr.xml/solrCloud that switches **both** Collectio

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1928: URL: https://github.com/apache/solr/pull/1928#issuecomment-1748368064 I split the changes related to `leaderEligible` into a separate PR: #1911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1748367502 Related to #1928 (split this particular change into a separate PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-05 Thread via GitHub
pvcnt opened a new pull request, #1981: URL: https://github.com/apache/solr/pull/1981 https://issues.apache.org/jira/browse/SOLR-16995 # Description A new `leaderEligible` property was introduced on the `Replica.Type` in Solr 9 (?), but it is currently not used much

Re: [I] Role Assignment for SOLR Replicas [solr-operator]

2023-10-05 Thread via GitHub
ozlerhakan commented on issue #618: URL: https://github.com/apache/solr-operator/issues/618#issuecomment-1748346189 When do you think you can consider this enhancement to be part of one of the next releases @HoustonPutman ? -- This is an automated message from the Apache Git Service. To

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

2023-10-05 Thread via GitHub
pvcnt commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346955921 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -325,20 +326,18 @@ public static List getNodesForNewReplicas( ClusterState clusterStat

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

2023-10-05 Thread via GitHub
pvcnt commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1346935984 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co