[ 
https://issues.apache.org/jira/browse/SOLR-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772438#comment-17772438
 ] 

ASF subversion and git services commented on SOLR-16924:
--------------------------------------------------------

Commit 8740b07efa8e78ab9ad1842cfd836e23b2cf6fd8 in solr's branch 
refs/heads/main from julia-maimone
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8740b07efa8 ]

SOLR-16924: RESTORECORE: make UpdateLog ACTIVE without requiring 
REQUESTAPPLYUPDATES (#1965)

RESTORECORE now sets the UpdateLog to ACTIVE state instead of requiring a 
separate REQUESTAPPLYUPDATES call in Collection restore. The latter will still 
happen in 9.x for backwards-compatibility.

---------

Co-authored-by: Julia Maimone <julia.maim...@salesforce.com>
Co-authored-by: David Smiley <dsmi...@salesforce.com>

> Restore: Have RESTORECORE set the UpdateLog state 
> --------------------------------------------------
>
>                 Key: SOLR-16924
>                 URL: https://issues.apache.org/jira/browse/SOLR-16924
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Priority: Minor
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This is a refactoring improvement designed to simplify & clarify a step in 
> collection restores.  One of the final phases of RestoreCmd (collection 
> restore) is to call REQUESTAPPLYUPDATES on each newly restored replica in 
> order to transition the state of the UpdateLog to ACTIVE (not actually to 
> apply updates).  The underlying call on the UpdateLog could instead be done 
> inside RESTORECORE at the end with explanatory comments as to the intent.  I 
> think this makes more sense that RESTORECORE finish with its UpdateLog ready. 
>  And it's strange/curious to see requests in the cluster to apply updates 
> from an updateLog when there is none to do!  Adding clarifying comments is 
> important.
> See my comment: 
> https://issues.apache.org/jira/browse/SOLR-12065?focusedCommentId=17751792&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17751792
> I think there isn't any back-compat concern.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to