[jira] [Commented] (SOLR-16701) Fetching PRS enabled collection might throw SolrException: Error fetching per-replica-states if the collection is deleted during the fetch

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768189#comment-17768189 ] ASF subversion and git services commented on SOLR-16701: Commit f

[jira] [Commented] (SOLR-16701) Fetching PRS enabled collection might throw SolrException: Error fetching per-replica-states if the collection is deleted during the fetch

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768188#comment-17768188 ] ASF subversion and git services commented on SOLR-16701: Commit f

[GitHub] [solr] magibney merged pull request #1460: SOLR-16701: Race condition on PRS enabled collection deletion

2023-09-22 Thread via GitHub
magibney merged PR #1460: URL: https://github.com/apache/solr/pull/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[GitHub] [solr] janhoy commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1732134302 Camel case support is now better. `getProp("solr.fooBar")` now falls back to `solr.foo.bar`. Also setting env `SOLR_FOO_BAR` will set both `solr.fooBar` due to the unstandard mapping, and `so

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334880267 ## solr/bin/solr: ## @@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then . "$SOLR_INCLUDE" fi +# Export variables we want to make visible to Solr sub-process +for

[GitHub] [solr] HoustonPutman opened a new pull request, #1951: Port defaulting should be the same for all tools

2023-09-22 Thread via GitHub
HoustonPutman opened a new pull request, #1951: URL: https://github.com/apache/solr/pull/1951 If Solr processes need to be found, port scanning will always be used. I need to make a JIRA for this, but this has been exhausting, so it can wait till later. Basically any Solr tool

[GitHub] [solr-sandbox] markrmiller commented on pull request #73: Documents lost in Consumer during target Solr restart.

2023-09-22 Thread via GitHub
markrmiller commented on PR #73: URL: https://github.com/apache/solr-sandbox/pull/73#issuecomment-1732049563 Taking a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] patsonluk commented on a diff in pull request #1460: SOLR-16701: Race condition on PRS enabled collection deletion

2023-09-22 Thread via GitHub
patsonluk commented on code in PR #1460: URL: https://github.com/apache/solr/pull/1460#discussion_r1334779855 ## solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java: ## @@ -129,15 +111,61 @@ public static boolean injectBreakpoint(String key, Object... args)

[GitHub] [solr] patsonluk commented on a diff in pull request #1460: SOLR-16701: Race condition on PRS enabled collection deletion

2023-09-22 Thread via GitHub
patsonluk commented on code in PR #1460: URL: https://github.com/apache/solr/pull/1460#discussion_r1334779433 ## solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java: ## @@ -129,15 +111,61 @@ public static boolean injectBreakpoint(String key, Object... args)

[jira] [Comment Edited] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768138#comment-17768138 ] Chris M. Hostetter edited comment on SOLR-16992 at 9/22/23 7:36 PM: ---

[jira] [Commented] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768138#comment-17768138 ] Chris M. Hostetter commented on SOLR-16992: --- {quote}... I fully agree the race

[GitHub] [solr] janhoy commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731938763 I added some refguide docs and some examples in `solr.in.sh/cmd`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] janhoy commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731938302 > One question about your envVar exporting in bin/solr. Is that command compatible across unix varieties? Yea, both `compgen` and `export` are built-in commands of bash, and the start

[jira] [Commented] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768131#comment-17768131 ] Alex Deparvu commented on SOLR-16992: - hmm, I think I'm leaning more towards option n

[jira] [Commented] (SOLR-16397) Cosmetic improvements and migration to JAX-RS ("core" APIs)

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768129#comment-17768129 ] ASF subversion and git services commented on SOLR-16397: Commit 5

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334729823 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] magibney commented on a diff in pull request #1460: SOLR-16701: Race condition on PRS enabled collection deletion

2023-09-22 Thread via GitHub
magibney commented on code in PR #1460: URL: https://github.com/apache/solr/pull/1460#discussion_r1334709570 ## solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java: ## @@ -129,15 +111,61 @@ public static boolean injectBreakpoint(String key, Object... args)

[GitHub] [solr-operator] gerlowskija opened a new pull request, #632: Default to Solr 8.11 for e2e tests

2023-09-22 Thread via GitHub
gerlowskija opened a new pull request, #632: URL: https://github.com/apache/solr-operator/pull/632 SOLR-16933 has been fixed for 9.4, but still exists in earlier releases in the 9.x line where it causes a number of e2e tests to fail their assertions. This commit is meant to workaround

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334695590 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334695590 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[jira] [Comment Edited] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768110#comment-17768110 ] Chris M. Hostetter edited comment on SOLR-16992 at 9/22/23 5:57 PM: ---

[jira] [Commented] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768110#comment-17768110 ] Chris M. Hostetter commented on SOLR-16992: --- {quote}given the proliferation of

[GitHub] [solr] cpoerschke commented on pull request #1950: SOLR-16994: facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-09-22 Thread via GitHub
cpoerschke commented on PR #1950: URL: https://github.com/apache/solr/pull/1950#issuecomment-1731817455 Tagging @tomglk and @alessandrobenedetti as potential reviewers, and reviews from others welcome too, of course. Thank you! -- This is an automated message from the Apache Git Service.

[GitHub] [solr] cpoerschke opened a new pull request, #1950: SOLR-16994: facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-09-22 Thread via GitHub
cpoerschke opened a new pull request, #1950: URL: https://github.com/apache/solr/pull/1950 https://issues.apache.org/jira/browse/SOLR-16994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [solr-operator] mlanner commented on issue #594: Solrcloud pods not starting with custom security.json

2023-09-22 Thread via GitHub
mlanner commented on issue #594: URL: https://github.com/apache/solr-operator/issues/594#issuecomment-1731771381 Hi @rekhasinghcali and @HoustonPutman, I've got a similar issue and I've tried a variety of things to make it work. I started out with just a plain Basic Auth implementatio

[jira] [Created] (SOLR-16994) facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-09-22 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-16994: -- Summary: facilitate date-related FieldValueFeature extensions (docValues=True only) Key: SOLR-16994 URL: https://issues.apache.org/jira/browse/SOLR-16994

[jira] [Commented] (SOLR-16979) Randomize ports in BATS tests

2023-09-22 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768093#comment-17768093 ] Houston Putman commented on SOLR-16979: --- Just figured out another bin/solr command

[jira] [Commented] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768087#comment-17768087 ] Alex Deparvu commented on SOLR-16992: - adding DeepRandomStream, FeaturesSelectionStre

[GitHub] [solr] laminelam commented on pull request #1949: SOLR-16991: Fix bug: Concurrent requests failing JWT Auth intermittently

2023-09-22 Thread via GitHub
laminelam commented on PR #1949: URL: https://github.com/apache/solr/pull/1949#issuecomment-1731718134 > Tip: Start he PR subject with "[SOLR-16991](https://issues.apache.org/jira/browse/SOLR-16991): ", then the jira number will occur in auto generated commit message and show up as a jira

[jira] [Commented] (SOLR-16992) Non-reproducible StreamingTest failures -- suggests CloudSolrStream concurency race condition

2023-09-22 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768085#comment-17768085 ] Alex Deparvu commented on SOLR-16992: - I agree with your analysis. makes perfect sens

[GitHub] [solr] risdenk commented on pull request #1945: SOLR-13833-setupRequest-improvements

2023-09-22 Thread via GitHub
risdenk commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1731701371 I fixed a similar race condition in [269d19b](https://github.com/apache/solr/pull/1945/commits/269d19b3a95b8de35130020facc8c47fab391c77) that makes sure there is a new leader before we try t

[jira] [Resolved] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter

2023-09-22 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-16925. --- Fix Version/s: 9.4 Assignee: Houston Putman Resolution: Fixed > Broken JSON i

[jira] [Commented] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768059#comment-17768059 ] ASF subversion and git services commented on SOLR-16925: Commit 1

[jira] [Commented] (SOLR-16925) Broken JSON indentation using JacksonJsonWriter

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768058#comment-17768058 ] ASF subversion and git services commented on SOLR-16925: Commit 1

[GitHub] [solr] HoustonPutman merged pull request #1942: SOLR-16925: Fix indentation for JacksonJsonWriter

2023-09-22 Thread via GitHub
HoustonPutman merged PR #1942: URL: https://github.com/apache/solr/pull/1942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr] HoustonPutman commented on pull request #1945: SOLR-13833-setupRequest-improvements

2023-09-22 Thread via GitHub
HoustonPutman commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1731602527 Yeah, I would love to see a caffeine implementation. Good find there! If we see really good improvements, it would be great to see Caffeine replace ConcurrentHashMap across the board.

[GitHub] [solr] iamsanjay commented on pull request #1933: SOLR-16397: Create v2(JAX-RS) endpoints for UNLOAD core

2023-09-22 Thread via GitHub
iamsanjay commented on PR #1933: URL: https://github.com/apache/solr/pull/1933#issuecomment-1731559176 > I went ahead and made these changes. With these changes, the build will now generate the following SolrRequest implementation "for free". Very cool IMO @gerlowskija Client code gen

[GitHub] [solr] risdenk commented on pull request #1945: SOLR-13833-setupRequest-improvements

2023-09-22 Thread via GitHub
risdenk commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1731554823 I ran into this reproducing failure - `gradlew test --tests LeaderElectionIntegrationTest.testSimpleSliceLeaderElection -Dtests.seed=7FE90E71BD77ABA3 -Dtests.locale=ga-Latn-IE -Dtests.timez

[GitHub] [solr] HoustonPutman commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
HoustonPutman commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731527834 > For sure my plan. Just want as many eyes as possible on the first foundation to detect flaws. When this is in, it also opens up for simplifying documentation, e.g. This is an

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
HoustonPutman commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334448322 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.

[jira] [Created] (SOLR-16993) Update components in solr 8.11.2 and 9.3.0

2023-09-22 Thread Rafael Rios Saavedra (Jira)
Rafael Rios Saavedra created SOLR-16993: --- Summary: Update components in solr 8.11.2 and 9.3.0 Key: SOLR-16993 URL: https://issues.apache.org/jira/browse/SOLR-16993 Project: Solr Issue T

[jira] [Updated] (SOLR-16993) Update libraries in solr 8.11.2 and 9.3.0

2023-09-22 Thread Rafael Rios Saavedra (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael Rios Saavedra updated SOLR-16993: Summary: Update libraries in solr 8.11.2 and 9.3.0 (was: Update components in solr

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2023-09-22 Thread Walter Underwood (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768021#comment-17768021 ] Walter Underwood commented on SOLR-15056: - Thanks, didn't see that when searching

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2023-09-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768008#comment-17768008 ] Jan Høydahl commented on SOLR-15056: It is there :) https://github.com/apache/solr/bl

[jira] [Commented] (SOLR-15056) CPU circuit breaker needs to use CPU utilization, not Unix load average

2023-09-22 Thread Walter Underwood (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768004#comment-17768004 ] Walter Underwood commented on SOLR-15056: - Just realized that I didn't add a line

[GitHub] [solr] janhoy commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731382216 > This is all looking really great @janhoy ... If the process of getting this done everywhere is a big job, make other jira's and maybe split them up by area so others can help? For su

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334344311 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] epugh commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
epugh commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731280854 This is all looking really great @janhoy ... If the process of getting this done everywhere is a big job, make other jira's and maybe split them up by area so others can help? -- Thi

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334271795 ## solr/core/src/java/org/apache/solr/pkg/PackageAPI.java: ## @@ -58,7 +59,7 @@ /** This implements the public end points (/api/cluster/package) of package API. */ public

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334269887 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] sigram commented on a diff in pull request #1928: Add a ReplicaCount to keep track of replicas per type

2023-09-22 Thread via GitHub
sigram commented on code in PR #1928: URL: https://github.com/apache/solr/pull/1928#discussion_r1334258677 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [solr-sandbox] sigram opened a new pull request, #73: Documents lost in Consumer during target Solr restart.

2023-09-22 Thread via GitHub
sigram opened a new pull request, #73: URL: https://github.com/apache/solr-sandbox/pull/73 This modified test illustrates a scenario when target Solr node(s) go missing (for example due to a crash, a forced restart, or connectivity issues) BUT at the same time the Zookeeper remains online.

[jira] [Resolved] (SOLR-16968) Use averages for Memory Circuit Breaker

2023-09-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16968. Fix Version/s: 9.4 Resolution: Fixed > Use averages for Memory Circuit Breaker > ---

[jira] [Commented] (SOLR-16968) Use averages for Memory Circuit Breaker

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767891#comment-17767891 ] ASF subversion and git services commented on SOLR-16968: Commit 2

[jira] [Commented] (SOLR-16968) Use averages for Memory Circuit Breaker

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767886#comment-17767886 ] ASF subversion and git services commented on SOLR-16968: Commit 8

[GitHub] [solr] janhoy merged pull request #1905: SOLR-16968: The MemoryCircuitBreaker now uses average heap usage

2023-09-22 Thread via GitHub
janhoy merged PR #1905: URL: https://github.com/apache/solr/pull/1905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16982) Trip a Circuit Breaker only for external requests

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767884#comment-17767884 ] ASF subversion and git services commented on SOLR-16982: Commit c

[jira] [Resolved] (SOLR-16982) Trip a Circuit Breaker only for external requests

2023-09-22 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16982. Fix Version/s: 9.4 Resolution: Fixed > Trip a Circuit Breaker only for external requests > -

[jira] [Commented] (SOLR-16982) Trip a Circuit Breaker only for external requests

2023-09-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767877#comment-17767877 ] ASF subversion and git services commented on SOLR-16982: Commit d

[GitHub] [solr] janhoy merged pull request #1930: SOLR-16982: Trip a Circuit Breaker only for external requests

2023-09-22 Thread via GitHub
janhoy merged PR #1930: URL: https://github.com/apache/solr/pull/1930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] janhoy commented on a diff in pull request #1930: SOLR-16982: Trip a Circuit Breaker only for external requests

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1930: URL: https://github.com/apache/solr/pull/1930#discussion_r1333975664 ## solr/CHANGES.txt: ## @@ -109,6 +109,8 @@ Improvements * SOLR-15474: Make Circuit breakers individually pluggable (Atri Sharma, Christine Poerschke, janhoy) +* SOLR

[GitHub] [solr] janhoy commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

2023-09-22 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1333971080 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [solr] janhoy commented on pull request #1949: Fix bug: Concurrent requests failing JWT Auth intermittently

2023-09-22 Thread via GitHub
janhoy commented on PR #1949: URL: https://github.com/apache/solr/pull/1949#issuecomment-1730907445 Tip: Start he PR subject with "SOLR-16991: ", then the jira number will occur in auto generated commit message and show up as a jira comment -- This is an automated message from the Apache