patsonluk commented on code in PR #1460:
URL: https://github.com/apache/solr/pull/1460#discussion_r1334779433
##########
solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java:
##########
@@ -129,15 +111,61 @@ public static boolean injectBreakpoint(String key,
Object... args) {
log.info("Breakpoint with key {} is triggered", key);
breakpoint.executeAndResume(args);
log.info("Breakpoint with key {} was executed and normal code execution
resumes", key);
+ } else {
+ log.info(
+ "Breakpoint with key {} is triggered but there's no implementation
set. Skipping...",
+ key);
Review Comment:
yes let's change that to debug, i was a bit concerned if someone
accidentally used different key names meant for the same Breakpoint for
`injectBreakpoint` and `setImplementation`, so with this log message they can
see whether the breakpoint is triggered.
Though I guess this could be really noisy as you pointed out, and I assume
the dev can search whether there's "Breakpoint with key ... is triggered"
message instead and absence of that means either the execution path does not
reach the breakpoint or the breakpoint has no implementation set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
