HoustonPutman commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1731527834
> For sure my plan. Just want as many eyes as possible on the first foundation to detect flaws. When this is in, it also opens up for simplifying documentation, e.g. This is an awesome start, and will be a huge boon to the project (or at least those working on things like the operator 😅 ). If we make `System.getProperty()` a forbidden API, it also makes it so that devs have to support EnvVars by default going forward, which I love. > * Deprecate use of all unstandard names e.g. `enable.packages` --> add alias `solr.packages.enable`. Defining and looking up aliases could also be part of `EnvUtils`. Yeah I was thinking that this code would be a great way of cleaning up and deprecating bad names of variables. (We just need to give a way for the operator to support 2 major versions, so remove the bad variables in Solr 10, but have them deprecated and replaced in a mid-version of Solr 9, like 9.5). One question about your envVar exporting in bin/solr. Is that command compatible across unix varieties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
