[jira] [Updated] (SOLR-15616) Allow thread metrics to be cached

2022-12-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-15616: Attachment: SOLR-15616-9x.patch Status: Open (was: Open) Updating patch fo

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645099#comment-17645099 ] Noble Paul commented on SOLR-16571: --- if you invoke any config API directly , it does no

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645086#comment-17645086 ] David Smiley commented on SOLR-16571: - How does the Config API depend on this? My ex

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645081#comment-17645081 ] Noble Paul commented on SOLR-16571: --- {quote}If we think people aren't likely using this

[jira] [Assigned] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-16571: - Assignee: Noble Paul > Add Java system property for ZooKeeper config watch > ---

[GitHub] [solr] dsmiley commented on pull request #1208: SOLR-16571: Add java system property to disable config watch

2022-12-08 Thread GitBox
dsmiley commented on PR #1208: URL: https://github.com/apache/solr/pull/1208#issuecomment-1343837114 Let's see where my comment goes on the parent JIRA. Note that this test fails no matter your change to no-op it :-). It's because you didn't actually create any collections. As we take th

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645072#comment-17645072 ] David Smiley commented on SOLR-16571: - As a side note, even though I also run Solr wi

[jira] [Commented] (SOLR-16571) Add Java system property for ZooKeeper config watch

2022-12-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645068#comment-17645068 ] David Smiley commented on SOLR-16571: - [~noblepaul], I didn't know there was such a w

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1224: [SOLR-16490] Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE

2022-12-08 Thread GitBox
sonatype-lift[bot] commented on code in PR #1224: URL: https://github.com/apache/solr/pull/1224#discussion_r1044057928 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] iamsanjay commented on pull request #1224: [SOLR-16490] Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE

2022-12-08 Thread GitBox
iamsanjay commented on PR #1224: URL: https://github.com/apache/solr/pull/1224#issuecomment-1343769347 Hello @gerlowskija, Response from the V2 API is squashed into the Solr Response without header using the method. `V2ApiUtils.squashIntoSolrResponseWithoutHeader(it.rsp, respon

[GitHub] [solr] iamsanjay opened a new pull request, #1224: [SOLR-16490] Create a v2 equivalent for /admin/cores BACKUPCORE+RESTORECORE

2022-12-08 Thread GitBox
iamsanjay opened a new pull request, #1224: URL: https://github.com/apache/solr/pull/1224 https://issues.apache.org/jira/browse/SOLR-16490 # Description The /admin/cores?action=BACKUPCORE API have no equivalent in the v2 paradigm. It's an internal API used by Collec

[jira] [Commented] (SOLR-16569) Add Java system property for overseer queue size

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645049#comment-17645049 ] ASF subversion and git services commented on SOLR-16569: Commit 6

[jira] [Resolved] (SOLR-16569) Add Java system property for overseer queue size

2022-12-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16569. --- Fix Version/s: 9.2 Resolution: Fixed > Add Java system property for overseer queue size >

[jira] [Commented] (SOLR-16569) Add Java system property for overseer queue size

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645048#comment-17645048 ] ASF subversion and git services commented on SOLR-16569: Commit 4

[GitHub] [solr] noblepaul merged pull request #1205: SOLR-16569: Add java system property to overseer queue size

2022-12-08 Thread GitBox
noblepaul merged PR #1205: URL: https://github.com/apache/solr/pull/1205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2022-12-08 Thread GitBox
sonatype-lift[bot] commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1043963255 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -0,0 +1,62 @@ +package org.apache.solr.opentelemetry; +

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2022-12-08 Thread GitBox
janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1043945805 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreement

[GitHub] [solr] risdenk commented on pull request #1223: test bats

2022-12-08 Thread GitBox
risdenk commented on PR #1223: URL: https://github.com/apache/solr/pull/1223#issuecomment-1343540626 Well @janhoy looks like its not just your change :) I haven't figured out how to collect the logs yet, but worth trying to figure out why its failing separate of your change. -- This is a

[jira] [Updated] (SOLR-16577) Core load issues are not always logged

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16577: Status: Patch Available (was: Open) > Core load issues are not always logged > ---

[GitHub] [solr] risdenk commented on a diff in pull request #1221: SOLR-16577: Always log core load issues

2022-12-08 Thread GitBox
risdenk commented on code in PR #1221: URL: https://github.com/apache/solr/pull/1221#discussion_r1043921139 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -973,29 +969,31 @@ public void load() { solrCores.markCoreAsLoading(cd); }

[jira] [Updated] (SOLR-16577) Core load issues are not always logged

2022-12-08 Thread Haythem Khiri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haythem Khiri updated SOLR-16577: - Description: It's possible for a core load failure to not have its cause logged. At least the fai

[jira] [Updated] (SOLR-16577) Core load issues are not always logged

2022-12-08 Thread Haythem Khiri (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haythem Khiri updated SOLR-16577: - Description: It's possible for a core load failure to not have its cause logged. At least the fai

[GitHub] [solr] epugh commented on pull request #1177: SOLR-16544: Adding documentation for how to contribute to Solr

2022-12-08 Thread GitBox
epugh commented on PR #1177: URL: https://github.com/apache/solr/pull/1177#issuecomment-1343410350 I love what you've done here. So, it feels like you have two potential PR's, one on the contributing to solr and the other on moving various `/help/*.txt` files out into proper `.adoc` forma

[GitHub] [solr-operator] ramayer commented on issue #498: Solr Operator seems very picky about the Kubernetes environment it's using (guessing networking/dns)

2022-12-08 Thread GitBox
ramayer commented on issue #498: URL: https://github.com/apache/solr-operator/issues/498#issuecomment-1343370987 Using minkube on Ubuntu, log files show messages like this: ``` java.net.UnknownHostException: example-solrcloud-zookeeper-1.example-solrcloud-zookeeper-headless.default

[GitHub] [solr] dsmiley commented on pull request #1216: SOLR-10458: setFollowRedirects should be deprecated in favor of Solr Client Builder methods

2022-12-08 Thread GitBox
dsmiley commented on PR #1216: URL: https://github.com/apache/solr/pull/1216#issuecomment-1343325282 for a boolean, arguably naming the method `followRedirects` would be fine without the "with" up front. Note other booleans like "compression" have a setter builder method: `allowCompression

[GitHub] [solr] dsmiley commented on a diff in pull request #1217: SOLR-10461: move setAliveCheckInterval from clients into Builder

2022-12-08 Thread GitBox
dsmiley commented on code in PR #1217: URL: https://github.com/apache/solr/pull/1217#discussion_r1043792886 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -301,14 +301,33 @@ public void onFailure(Throwable oe) { public static class Buil

[GitHub] [solr] dsmiley commented on a diff in pull request #1219: SOLR-10462: migrate to using the Builder setting the pollQueueTime

2022-12-08 Thread GitBox
dsmiley commented on code in PR #1219: URL: https://github.com/apache/solr/pull/1219#discussion_r1043786321 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateHttp2SolrClient.java: ## @@ -795,6 +807,14 @@ public Builder neverStreamDeletes() { return

[GitHub] [solr] ben-manes commented on a diff in pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-08 Thread GitBox
ben-manes commented on code in PR #1155: URL: https://github.com/apache/solr/pull/1155#discussion_r1043745746 ## solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java: ## @@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer coreContainer)

[GitHub] [solr] dsmiley commented on pull request #1221: SOLR-16577: Always log core load issues

2022-12-08 Thread GitBox
dsmiley commented on PR #1221: URL: https://github.com/apache/solr/pull/1221#issuecomment-1343014214 FYI everyone, I already code reviewed this. BTW a nice improvement here is that we remove needless complexity. These Futures were pointless. Perhaps there was once a point to them bu

[jira] [Resolved] (SOLR-10458) setFollowRedirects should be deprecated in favor of SolrClientBuilder methods

2022-12-08 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-10458. -- Fix Version/s: 9.2 Resolution: Fixed > setFollowRedirects should be deprecated in favor of SolrC

[jira] [Commented] (SOLR-10458) setFollowRedirects should be deprecated in favor of SolrClientBuilder methods

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644893#comment-17644893 ] ASF subversion and git services commented on SOLR-10458: Commit 8

[jira] [Commented] (SOLR-10458) setFollowRedirects should be deprecated in favor of SolrClientBuilder methods

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644892#comment-17644892 ] ASF subversion and git services commented on SOLR-10458: Commit 4

[GitHub] [solr] epugh merged pull request #1216: SOLR-10458: setFollowRedirects should be deprecated in favor of Solr Client Builder methods

2022-12-08 Thread GitBox
epugh merged PR #1216: URL: https://github.com/apache/solr/pull/1216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr-operator] HoustonPutman commented on issue #503: solr-operator-zookeeper-operator-pre-delete job node selector

2022-12-08 Thread GitBox
HoustonPutman commented on issue #503: URL: https://github.com/apache/solr-operator/issues/503#issuecomment-1342970761 Awesome, thanks for sharing your fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] risdenk commented on pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-12-08 Thread GitBox
risdenk commented on PR #1089: URL: https://github.com/apache/solr/pull/1089#issuecomment-1342933419 > I wonder why the BATS test keeps failing? Not sure - I created https://github.com/apache/solr/pull/1223 which just changes the github actions file. This is to try to eliminate your c

[jira] [Updated] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16562: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade to Caffeine 3.1.2 > --

[jira] [Updated] (SOLR-16578) Upgrade to errorprone 2.16

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16578: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade to errorprone 2.16 > -

[jira] [Updated] (SOLR-16578) Upgrade to errorprone 2.16

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16578: Fix Version/s: 9.2 > Upgrade to errorprone 2.16 > -- > > Ke

[jira] [Commented] (SOLR-16578) Upgrade to errorprone 2.16

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644862#comment-17644862 ] ASF subversion and git services commented on SOLR-16578: Commit 5

[jira] [Updated] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16579: Fix Version/s: 9.2 > Upgrade Jackson to 2.14.1 > - > > Key:

[jira] [Commented] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644863#comment-17644863 ] ASF subversion and git services commented on SOLR-16562: Commit 2

[jira] [Commented] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644861#comment-17644861 ] ASF subversion and git services commented on SOLR-16579: Commit 2

[jira] [Updated] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16579: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade Jackson to 2.14.1 > --

[jira] [Updated] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16562: Fix Version/s: 9.2 > Upgrade to Caffeine 3.1.2 > - > > Key:

[jira] [Updated] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16579: Fix Version/s: main (10.0) > Upgrade Jackson to 2.14.1 > - > >

[jira] [Updated] (SOLR-16578) Upgrade to errorprone 2.16

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16578: Fix Version/s: main (10.0) > Upgrade to errorprone 2.16 > -- > >

[jira] [Updated] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16562: Fix Version/s: main (10.0) > Upgrade to Caffeine 3.1.2 > - > >

[jira] [Commented] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644856#comment-17644856 ] ASF subversion and git services commented on SOLR-16562: Commit 8

[jira] [Commented] (SOLR-16579) Upgrade Jackson to 2.14.1

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644854#comment-17644854 ] ASF subversion and git services commented on SOLR-16579: Commit c

[jira] [Commented] (SOLR-16578) Upgrade to errorprone 2.16

2022-12-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644855#comment-17644855 ] ASF subversion and git services commented on SOLR-16578: Commit 0

[GitHub] [solr] risdenk merged pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-12-08 Thread GitBox
risdenk merged PR #1198: URL: https://github.com/apache/solr/pull/1198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16568) Update woodstox-core to 6.4.0 to mitigate CVE-2022-40152

2022-12-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644853#comment-17644853 ] Kevin Risden commented on SOLR-16568: - [~gus] be my guest. I don't think its worth it

[jira] [Commented] (SOLR-16568) Update woodstox-core to 6.4.0 to mitigate CVE-2022-40152

2022-12-08 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644847#comment-17644847 ] Gus Heck commented on SOLR-16568: - I'm not sure this should be closed without adding eith

[GitHub] [solr] bruno-roustant commented on a diff in pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-08 Thread GitBox
bruno-roustant commented on code in PR #1155: URL: https://github.com/apache/solr/pull/1155#discussion_r1043219211 ## solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java: ## @@ -70,10 +80,15 @@ public TransientSolrCoreCacheDefault(CoreContainer coreContai

[GitHub] [solr] bruno-roustant commented on a diff in pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-08 Thread GitBox
bruno-roustant commented on code in PR #1155: URL: https://github.com/apache/solr/pull/1155#discussion_r1043152924 ## solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java: ## @@ -47,6 +49,14 @@ public class TransientSolrCoreCacheDefault extends TransientSo

[GitHub] [solr] janhoy commented on pull request #1089: SOLR-16475 Make the default replica placement plugin configurable

2022-12-08 Thread GitBox
janhoy commented on PR #1089: URL: https://github.com/apache/solr/pull/1089#issuecomment-1342260703 I wonder why the BATS test keeps failing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s