dsmiley commented on PR #1216: URL: https://github.com/apache/solr/pull/1216#issuecomment-1343325282
for a boolean, arguably naming the method `followRedirects` would be fine without the "with" up front. Note other booleans like "compression" have a setter builder method: `allowCompression` and there are probably others. I think the point is for it to read nicer. The "with" isn't wrong but removing it is just as clear, thus why have a superfluous word. FWIW @anshumg added the Builders long ago from what I see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
