dsmiley commented on code in PR #1217:
URL: https://github.com/apache/solr/pull/1217#discussion_r1043792886
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -301,14 +301,33 @@ public void onFailure(Throwable oe) {
public static class Builder {
private final Http2SolrClient http2Client;
private final String[] baseSolrUrls;
+ private int interval;
Review Comment:
aliveCheckInterval would be clearer!
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -301,14 +301,33 @@ public void onFailure(Throwable oe) {
public static class Builder {
private final Http2SolrClient http2Client;
private final String[] baseSolrUrls;
+ private int interval;
public Builder(Http2SolrClient http2Client, String... baseSolrUrls) {
this.http2Client = http2Client;
this.baseSolrUrls = baseSolrUrls;
}
+ /**
+ * LBHttpSolrServer keeps pinging the dead servers at fixed interval to
find if it is alive. Use
+ * this to set that interval
+ *
+ * @param interval time in milliseconds
+ */
+ public LBHttp2SolrClient.Builder setAliveCheckInterval(int interval) {
Review Comment:
use "with" builder naming convention
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java:
##########
@@ -259,6 +261,21 @@ public Builder withBaseSolrUrls(String... solrUrls) {
return this;
}
+ /**
+ * LBHttpSolrServer keeps pinging the dead servers at fixed interval to
find if it is alive. Use
+ * this to set that interval
+ *
+ * @param interval time in milliseconds
+ */
+ public Builder setAliveCheckInterval(int interval) {
Review Comment:
use "with" builder naming convention
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java:
##########
@@ -301,14 +301,33 @@ public void onFailure(Throwable oe) {
public static class Builder {
private final Http2SolrClient http2Client;
private final String[] baseSolrUrls;
+ private int interval;
Review Comment:
On the other hand, this merely uses the very same field name used in the
client so... let's either change them all or leave them all (as you wish).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
