[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545739#comment-17545739 ] David Smiley commented on SOLR-14699: - Joel: Thanks for trying it out! Supporting bo

[GitHub] [solr] dsmiley commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
dsmiley commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888568793 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,35 @@ // specific language governing permissions and limitations // under the L

[GitHub] [solr] epugh commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145508140 I think we are good? We should spin off into a new issue clarifying the docs on the gson dependency for Jaeger. I re-requested reviews from folks, and would love to merge on Friday. -- Th

[GitHub] [solr] noblepaul opened a new pull request, #893: A raw Solr request

2022-06-02 Thread GitBox
noblepaul opened a new pull request, #893: URL: https://github.com/apache/solr/pull/893 PoC. DO NOT merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[jira] [Created] (SOLR-16234) An API to make raw requests and responses to Solr

2022-06-02 Thread Noble Paul (Jira)
Noble Paul created SOLR-16234: - Summary: An API to make raw requests and responses to Solr Key: SOLR-16234 URL: https://issues.apache.org/jira/browse/SOLR-16234 Project: Solr Issue Type: Improve

[GitHub] [solr-sandbox] markrmiller merged pull request #20: Simplify build artifacts.

2022-06-02 Thread GitBox
markrmiller merged PR #20: URL: https://github.com/apache/solr-sandbox/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.a

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Status: Patch Available (was: Open) > JWT-Auth: Support for Keycloak-Style nested roles > --

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Description: The _rolesClaim_ for a JWT Token, as documented in [https://solr.apache.org/guide/8_11/jwt-authenti

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Description: The _rolesClaim_ for a JWT Token, as documented in [https://solr.apache.org/guide/8_11/jwt-authenti

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-06-02 Thread GitBox
sonatype-lift[bot] commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r888388338 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -595,7 +595,20 @@ protected JWTAuthenticationResponse authenticate(String

[GitHub] [solr] col-panic commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-06-02 Thread GitBox
col-panic commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r888388313 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -595,7 +595,20 @@ protected JWTAuthenticationResponse authenticate(String authoriz

[GitHub] [solr] epugh commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145292493 🚢 🚢 🚢 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [solr-sandbox] markrmiller opened a new pull request, #20: Simplify build artifacts.

2022-06-02 Thread GitBox
markrmiller opened a new pull request, #20: URL: https://github.com/apache/solr-sandbox/pull/20 Changes cross-dc producer and crossdc-commons to create a single uber jar output file and does a bit of work to ensure the resulting artifacts do not include unnecessary dependencies or duplicat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888350419 ## solr/solr-ref-guide/modules/query-guide/pages/learning-to-rank.adoc: ## @@ -111,11 +111,15 @@ In the form of JSON files your trained model or models (e.g., differen

[GitHub] [solr] HoustonPutman commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145269031 > This ship has probably sailed, but are we going to run into issues with Solr Modules v Java Modules at some point? I don't think so... It would be worse if we were mainly a java

[GitHub] [solr] madrob commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
madrob commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145223094 This ship has probably sailed, but are we going to run into issues with Solr Modules v Java Modules at some point? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888292055 ## solr/solr-ref-guide/modules/query-guide/pages/learning-to-rank.adoc: ## @@ -111,11 +111,15 @@ In the form of JSON files your trained model or models (e.g., different models

[jira] [Created] (SOLR-16233) Add HTTP headers support to LogUpdateProcessorFactory

2022-06-02 Thread Lamine (Jira)
Lamine created SOLR-16233: - Summary: Add HTTP headers support to LogUpdateProcessorFactory Key: SOLR-16233 URL: https://issues.apache.org/jira/browse/SOLR-16233 Project: Solr Issue Type: New Feature

[GitHub] [solr] gerlowskija commented on pull request #888: SOLR-15743: Convert v2 GET /config APIs to annotations

2022-06-02 Thread GitBox
gerlowskija commented on PR #888: URL: https://github.com/apache/solr/pull/888#issuecomment-1145118553 Thanks for the once-over @epugh. I've got commits and tests passing, so I'm aiming to merge in the next day or two. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [solr] HoustonPutman commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888192270 ## solr/solr-ref-guide/modules/query-guide/pages/learning-to-rank.adoc: ## @@ -111,11 +111,15 @@ In the form of JSON files your trained model or models (e.g., differen

[GitHub] [solr] HoustonPutman commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888188961 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under

[GitHub] [solr] HoustonPutman commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888188961 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888183276 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under the Lic

[jira] [Commented] (SOLR-15585) Graceful shutdown can cause data loss with PULL replicas

2022-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545556#comment-17545556 ] David Smiley commented on SOLR-15585: - Are we calling this "data loss" for the durati

[GitHub] [solr] HoustonPutman commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145085688 Seriously thanks for the great work here! It should be much much clearer to users going forward 🙂 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [solr] epugh commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145084881 > @HoustonPutman If we don't put `[Solr Module]` in the links, then the text is plural: > > _This is provided via the jaegertracer-configurator **Solr Modules** that needs to be enabled b

[GitHub] [solr] epugh commented on pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on PR #889: URL: https://github.com/apache/solr/pull/889#issuecomment-1145082303 @HoustonPutman If we don't put `[Solr Module]` in the links, then the text is plural: _This is provided via the jaegertracer-configurator __Solr Modules__ that needs to be enabled before

[jira] [Closed] (SOLR-16210) Lift Configuration Change to Correct failing Lift Tools

2022-06-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-16210. --- Assignee: David Smiley > Lift Configuration Change to Correct failing Lift Tools > --

[jira] [Updated] (SOLR-16229) Interrupted queries block subsequent query execution

2022-06-02 Thread Daniel Rabus (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Rabus updated SOLR-16229: Summary: Interrupted queries block subsequent query execution (was: Interrupted queries result in

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888162638 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under the Lic

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888161132 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under the Lic

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888156823 ## solr/solr-ref-guide/modules/indexing-guide/pages/indexing-with-update-handlers.adoc: ## @@ -18,15 +18,15 @@ // under the License. Update handlers are request handlers de

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888153863 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under the Lic

[GitHub] [solr] HoustonPutman opened a new pull request, #892: SOLR-16232: Fix EnvVar usage in bin/solr

2022-06-02 Thread GitBox
HoustonPutman opened a new pull request, #892: URL: https://github.com/apache/solr/pull/892 https://issues.apache.org/jira/browse/SOLR-16232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888152926 ## solr/solr-ref-guide/modules/configuration-guide/pages/solr-modules.adoc: ## @@ -17,32 +17,34 @@ // specific language governing permissions and limitations // under the Lic

[jira] [Created] (SOLR-16232) Fix EnvVar bugs in bin/solr

2022-06-02 Thread Houston Putman (Jira)
Houston Putman created SOLR-16232: - Summary: Fix EnvVar bugs in bin/solr Key: SOLR-16232 URL: https://issues.apache.org/jira/browse/SOLR-16232 Project: Solr Issue Type: Bug Security Lev

[GitHub] [solr] HoustonPutman commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
HoustonPutman commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888085612 ## solr/solr-ref-guide/modules/configuration-guide/pages/configuring-solr-xml.adoc: ## @@ -183,9 +183,9 @@ Note that specifying `sharedLib` will not remove `$SOLR_HOME

[GitHub] [solr] magibney commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
magibney commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887942257 ## solr/solr-ref-guide/modules/indexing-guide/pages/indexing-with-update-handlers.adoc: ## @@ -18,15 +18,15 @@ // under the License. Update handlers are request handlers

[GitHub] [solr] dsmiley commented on a diff in pull request #887: SOLR-16227 Use local params value syntax for phrase queries

2022-06-02 Thread GitBox
dsmiley commented on code in PR #887: URL: https://github.com/apache/solr/pull/887#discussion_r888078349 ## solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrFilter.java: ## @@ -362,8 +363,9 @@ protected String translateLike(RexNode like) { // but that expects t

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888074015 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses Ja

[GitHub] [solr] dsmiley commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
dsmiley commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r888068383 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses

[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-02 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r888042243 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,72 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[GitHub] [solr-operator] HoustonPutman commented on issue #424: Why Solr Operator local tutorial show 404 error??

2022-06-02 Thread GitBox
HoustonPutman commented on issue #424: URL: https://github.com/apache/solr-operator/issues/424#issuecomment-1144974766 Thanks for finding that @mangohero1985 , we can get that updated in the tutorial -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [solr] HoustonPutman opened a new pull request, #891: SOLR-16231: Fix links to ref-guide pages

2022-06-02 Thread GitBox
HoustonPutman opened a new pull request, #891: URL: https://github.com/apache/solr/pull/891 https://issues.apache.org/jira/browse/SOLR-16231 As of the 9.0.0 release, our ref-guide page links have changed considerably. We have created redirects for most of these, but still the codebase

[GitHub] [solr-operator] mangohero1985 commented on issue #424: Why Solr Operator local tutorial show 404 error??

2022-06-02 Thread GitBox
mangohero1985 commented on issue #424: URL: https://github.com/apache/solr-operator/issues/424#issuecomment-1144970837 @Seunghan-Jung Inspired by this link https://forum.linuxfoundation.org/discussion/859965/exercise-7-nginx-update-requires-change-to-yaml `$kubectl edit ingress exampl

[jira] [Created] (SOLR-16231) Fix ref-guide links across the codebase

2022-06-02 Thread Houston Putman (Jira)
Houston Putman created SOLR-16231: - Summary: Fix ref-guide links across the codebase Key: SOLR-16231 URL: https://issues.apache.org/jira/browse/SOLR-16231 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-16188) Antora generates wrong .htaccess file

2022-06-02 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545505#comment-17545505 ] Houston Putman commented on SOLR-16188: --- I think this issue is fine to close. We ar

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #890: SOLR-16230: JWT nested roles support

2022-06-02 Thread GitBox
sonatype-lift[bot] commented on code in PR #890: URL: https://github.com/apache/solr/pull/890#discussion_r888018935 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTAuthPlugin.java: ## @@ -595,7 +595,20 @@ protected JWTAuthenticationResponse authenticate(String

[jira] [Resolved] (SOLR-16208) Unable to delete async task ID

2022-06-02 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16208. Resolution: Invalid Hi [~ssunka] We try to reserve JIRA for confirmed bugs or improvements

[jira] [Commented] (SOLR-14699) Solr request logs should escape names, values (SolrQueryResponse.getToLogAsString)

2022-06-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545488#comment-17545488 ] Joel Bernstein commented on SOLR-14699: --- I tested out the PR and it looks good. I g

[jira] [Commented] (SOLR-16202) Need a way to control what documents get returned by graph query parser

2022-06-02 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545485#comment-17545485 ] Jason Gerlowski commented on SOLR-16202: Hey [~ndipiazza_gmail] - cool idea. Cou

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887940274 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,8 +240,11 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] laminelam commented on pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on PR #857: URL: https://github.com/apache/solr/pull/857#issuecomment-1144887062 > I think we need to have a bigger discussion around backwards compatibility and how we achieve that. > > I would prefer to keep everything nice and neat, instead of spreading cl

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887960327 ## solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java: ## @@ -529,6 +529,9 @@ private static CloudConfig fillSolrCloudSection( case "zkCredentialsProvider"

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887955841 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/package-info.java: ## @@ -0,0 +1,19 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] col-panic opened a new pull request, #890: SOLR-16230: JWT nested roles support

2022-06-02 Thread GitBox
col-panic opened a new pull request, #890: URL: https://github.com/apache/solr/pull/890 [16230](https://issues.apache.org/jira/browse/SOLR-16230) # Description JWT-Auth: Support for Keycloak-Style nested roles # Solution Introduce the support for `dot-notation` in

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Description: The _rolesClaim_ for a JWT Token, as documented in [https://solr.apache.org/guide/8_11/jwt-authenti

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Description: The _rolesClaim_ for a JWT Token, as documented in [https://solr.apache.org/guide/8_11/jwt-authenti

[jira] [Updated] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco updated SOLR-16230: - Description: The _rolesClaim_ for a JWT Token, as documented in [https://solr.apache.org/guide/8_11/jwt-authenti

[jira] [Created] (SOLR-16230) JWT-Auth: Support for Keycloak-Style nested roles

2022-06-02 Thread Marco (Jira)
Marco created SOLR-16230: Summary: JWT-Auth: Support for Keycloak-Style nested roles Key: SOLR-16230 URL: https://issues.apache.org/jira/browse/SOLR-16230 Project: Solr Issue Type: New Feature

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887944716 ## solr/solrj/src/java/org/apache/solr/common/cloud/acl/DigestZkCredentialsProvider.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887940274 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,8 +240,11 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] laminelam commented on a diff in pull request #857: SOLR-16192: Add ZK credentials injectors support

2022-06-02 Thread GitBox
laminelam commented on code in PR #857: URL: https://github.com/apache/solr/pull/857#discussion_r887940274 ## solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -236,8 +240,11 @@ protected ZkCredentialsProvider createZkCredentialsToAddAutomatically() {

[GitHub] [solr] NazerkeBS commented on pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-02 Thread GitBox
NazerkeBS commented on PR #882: URL: https://github.com/apache/solr/pull/882#issuecomment-1144848113 I updated `SolrLogPostTool` but not the entire TestSolrLogPostTool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] NazerkeBS commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-02 Thread GitBox
NazerkeBS commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r887922668 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -893,7 +893,7 @@ private void handleAdminRequest() throws IOException { handler != null

[jira] [Created] (SOLR-16229) Interrupted queries result in delayed subsequent query execution

2022-06-02 Thread Daniel Rabus (Jira)
Daniel Rabus created SOLR-16229: --- Summary: Interrupted queries result in delayed subsequent query execution Key: SOLR-16229 URL: https://issues.apache.org/jira/browse/SOLR-16229 Project: Solr

[GitHub] [solr] janhoy commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
janhoy commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887866417 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses J

[GitHub] [solr] janhoy commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
janhoy commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887866417 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses J

[GitHub] [solr] janhoy commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
janhoy commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887863710 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses J

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887862368 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses Ja

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887861140 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-7.adoc: ## @@ -230,7 +230,7 @@ Mentions of deprecations are likely superseded by removal in Solr 7, as

[GitHub] [solr] janhoy commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
janhoy commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887861137 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses J

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887860658 ## solr/solr-ref-guide/modules/query-guide/pages/learning-to-rank.adoc: ## @@ -113,7 +113,7 @@ In the form of JSON files your trained model or models (e.g., different models f

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887854459 ## solr/solr-ref-guide/modules/indexing-guide/pages/language-analysis.adoc: ## @@ -692,16 +692,16 @@ On the other hand, it can reduce precision because language-specific chara

[GitHub] [solr] epugh commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
epugh commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887853329 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -51,7 +57,7 @@ https://docs.datadoghq.com/tracing/setup/java/[datadog-java-agent] uses Ja

[GitHub] [solr] janhoy commented on a diff in pull request #889: SOLR-16228: Audit how we refer to Solr Modules

2022-06-02 Thread GitBox
janhoy commented on code in PR #889: URL: https://github.com/apache/solr/pull/889#discussion_r887635013 ## solr/solr-ref-guide/modules/configuration-guide/pages/configuring-solr-xml.adoc: ## @@ -183,9 +183,9 @@ Note that specifying `sharedLib` will not remove `$SOLR_HOME/lib` f